From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932466AbbI3Qnm (ORCPT ); Wed, 30 Sep 2015 12:43:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45361 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754805AbbI3Qng (ORCPT ); Wed, 30 Sep 2015 12:43:36 -0400 Date: Wed, 30 Sep 2015 18:40:26 +0200 From: Oleg Nesterov To: Tetsuo Handa Cc: akpm@linux-foundation.org, rientjes@google.com, kwalker@redhat.com, mhocko@kernel.org, skozina@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] coredump: make SIGNAL_GROUP_COREDUMP more friendly to oom-killer Message-ID: <20150930164026.GA9505@redhat.com> References: <20150929155446.GA15095@redhat.com> <201509302049.DCD56245.HQFVtFJOSMOLOF@I-love.SAKURA.ne.jp> <20150930141552.GF32263@redhat.com> <201510010112.FAB18244.OFtFMSFJLVOOQH@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201510010112.FAB18244.OFtFMSFJLVOOQH@I-love.SAKURA.ne.jp> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01, Tetsuo Handa wrote: > > Oleg Nesterov wrote: > > This patch just makes the SIGNAL_GROUP_COREDUMP check in task_will_free_mem() > > a bit more correct wrt CLONE_VM tasks, nothing more. > > OK. Then, that's out of what I can understand. But I wish for > some description to PATCH 2/2 about why to change from > "do { } while_each_thread()" to "for_each_thread() { }" while_each_thread() is deprecated, see 0c740d0afc > because they seem to traverse differently. Not really. And in this particular case (start from group leader) even the order is the same, although this doesn't matter. Well, except for_each_thread(p, t) can find no threads, but this is fine too; this means that they all (including the leader) have exited. Oleg.