From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932958AbbI3SIl (ORCPT ); Wed, 30 Sep 2015 14:08:41 -0400 Received: from v-smtpgw2.han.skanova.net ([81.236.60.205]:55350 "EHLO v-smtpgw2.han.skanova.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbbI3SIk (ORCPT ); Wed, 30 Sep 2015 14:08:40 -0400 X-Greylist: delayed 361 seconds by postgrey-1.27 at vger.kernel.org; Wed, 30 Sep 2015 14:08:39 EDT Date: Wed, 30 Sep 2015 20:02:34 +0200 From: Jesper Nilsson To: Andy Shevchenko Cc: Jesper Nilsson , Mikael Starvik , Jesper Nilsson , linux-cris-kernel , "linux-kernel@vger.kernel.org" , Geert Uytterhoeven Subject: Re: [PATCH] cris: kgdb: use native hex2bin Message-ID: <20150930180234.GA6732@jni.nu> References: <1370335914-31582-1-git-send-email-andriy.shevchenko@linux.intel.com> <1443624413.8361.305.camel@linux.intel.com> <20150930152224.GZ4919@axis.com> <1443627471.8361.314.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443627471.8361.314.camel@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CMAE-Envelope: MS4wfHUOorvgOLjK+JjamlHK1YSTuQcQpfNNQc1bIi/UZzGepM+sPb2szO0mnZvO6ZXiGZIi/ywS/Cmmh6JLuThuCYnronokBfJA7ReECkTyBQYFBNyFON2vOJ3JGNjRZggHQajwtOoy8dcSI2ZLJtPS25bfxTfFcBYiIExTCT6CkgUdPYQpu95ch37XuXuaf/HxNznW8AxVB5XOlsfcS4CRWPALaN62F+ZCxDsrjtAGOt7aa5sH6WirWhfsxBMSeqWNyvRKA7wXxfuWd5JimBv12FlXMzTbDDQ2h0mhvDkzxyTeyIgKY2jUtPtsuIcxndRGQRxd8ID/XG8YUSPy76uQfgNfUmntLJ1wIlfbaKl4qRF6vNzWHHtsGGuukxt0Er1G7A== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 06:37:51PM +0300, Andy Shevchenko wrote: > On Wed, 2015-09-30 at 17:22 +0200, Jesper Nilsson wrote: > > On Wed, Sep 30, 2015 at 04:46:53PM +0200, Andy Shevchenko wrote: > > > On Tue, 2013-06-04 at 11:51 +0300, Andy Shevchenko wrote: > > > > There are kernel native helpers to convert hex ascii to the > > > > binary > > > > format: > > > > hex_to_bin() and hex2bin(). Thus, no need to reimplement them > > > > customly. > > > > > > > > > > No one is interested in this? > > > > Hm, dunno why, but obviously I've missed these patches, > > and I can't find them on my main mailaccount either. > > > > Anyways, I found them on a secondary account, and have > > added them to the CRIS linux-next tree. > > Just noticed that it was along time ago and currently it might produce > compile warnings or errors since now hex2bin is prefixed by > __must_check. > > Would you like me to send v2? Unless you've tweaked them more since you sent them, it shouldn't be necessary, the patches applied cleanly. Those (most) files in CRIS are not touched very often... :-) > Andy Shevchenko /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper_at_jni.nu