From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Jesper Nilsson <jesper@jni.nu>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jesper Nilsson <jespern@axis.com>,
Mikael Starvik <starvik@axis.com>,
linux-cris-kernel <linux-cris-kernel@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] cris: kgdb: use native hex2bin
Date: Wed, 30 Sep 2015 20:11:54 +0200 [thread overview]
Message-ID: <20150930181154.GA4919@axis.com> (raw)
In-Reply-To: <20150930180234.GA6732@jni.nu>
On Wed, Sep 30, 2015 at 08:02:34PM +0200, Jesper Nilsson wrote:
> On Wed, Sep 30, 2015 at 06:37:51PM +0300, Andy Shevchenko wrote:
> > On Wed, 2015-09-30 at 17:22 +0200, Jesper Nilsson wrote:
> > > On Wed, Sep 30, 2015 at 04:46:53PM +0200, Andy Shevchenko wrote:
> > > > On Tue, 2013-06-04 at 11:51 +0300, Andy Shevchenko wrote:
> > > > > There are kernel native helpers to convert hex ascii to the
> > > > > binary
> > > > > format:
> > > > > hex_to_bin() and hex2bin(). Thus, no need to reimplement them
> > > > > customly.
> > > > >
> > > >
> > > > No one is interested in this?
> > >
> > > Hm, dunno why, but obviously I've missed these patches,
> > > and I can't find them on my main mailaccount either.
> > >
> > > Anyways, I found them on a secondary account, and have
> > > added them to the CRIS linux-next tree.
> >
> > Just noticed that it was along time ago and currently it might produce
> > compile warnings or errors since now hex2bin is prefixed by
> > __must_check.
> >
> > Would you like me to send v2?
>
> Unless you've tweaked them more since you sent them,
> it shouldn't be necessary, the patches applied cleanly.
> Those (most) files in CRIS are not touched very often... :-)
... and now I saw your v2, I'll take that instead since
you already fixed the __must_check problems.
Thanks a lot!
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2015-09-30 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 8:51 [PATCH] cris: kgdb: use native hex2bin Andy Shevchenko
2013-06-04 9:33 ` Andy Shevchenko
2015-09-30 14:46 ` Andy Shevchenko
2015-09-30 15:22 ` Jesper Nilsson
2015-09-30 15:37 ` Andy Shevchenko
2015-09-30 18:02 ` Jesper Nilsson
2015-09-30 18:11 ` Jesper Nilsson [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-23 20:09 Exotic architecture fixes Geert Uytterhoeven
2013-05-28 15:53 ` [PATCH] arch/cris: old patch to use hex2bin Andy Shevchenko
2013-05-28 15:53 ` [PATCH] cris: kgdb: use native hex2bin Andy Shevchenko
2013-05-30 7:57 ` Geert Uytterhoeven
2013-05-30 9:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930181154.GA4919@axis.com \
--to=jesper.nilsson@axis.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=jesper@jni.nu \
--cc=jespern@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).