From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932911AbbI3VDT (ORCPT ); Wed, 30 Sep 2015 17:03:19 -0400 Received: from mail-yk0-f182.google.com ([209.85.160.182]:35095 "EHLO mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932663AbbI3VDR (ORCPT ); Wed, 30 Sep 2015 17:03:17 -0400 X-Google-Original-Sender: Date: Wed, 30 Sep 2015 17:04:37 -0400 From: Johan Hovold To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Lee Jones , Samuel Ortiz Subject: Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic Message-ID: <20150930210437.GF4284@localhost> References: <1443525968-30899-1-git-send-email-javier@osg.samsung.com> <1443525968-30899-9-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443525968-30899-9-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2015 at 01:26:08PM +0200, Javier Martinez Canillas wrote: > The invoked functions already return zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas I do not consider this an improvement in any way and suggest this patch is dropped. > --- > > drivers/mfd/lm3533-core.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c > index 643f3750e830..193ecee1fa7e 100644 > --- a/drivers/mfd/lm3533-core.c > +++ b/drivers/mfd/lm3533-core.c > @@ -472,11 +472,7 @@ static int lm3533_device_setup(struct lm3533 *lm3533, > if (ret) > return ret; > > - ret = lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); > - if (ret) > - return ret; > - > - return 0; > + return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); You're saving a few lines of code but instead introduce asymmetries and obscure the fact that the function returns zero on success. Johan