From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751434AbbJAFwE (ORCPT ); Thu, 1 Oct 2015 01:52:04 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:46267 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbbJAFwB (ORCPT ); Thu, 1 Oct 2015 01:52:01 -0400 Date: Thu, 1 Oct 2015 07:51:57 +0200 From: Sascha Hauer To: Mark Brown Cc: Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: core: Handle probe deferral from DT when resolving supplies Message-ID: <20151001055157.GF7858@pengutronix.de> References: <1443641452-21824-1-git-send-email-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443641452-21824-1-git-send-email-broonie@kernel.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 07:51:14 up 11 days, 19:20, 64 users, load average: 0.02, 0.07, 0.12 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2015 at 08:30:52PM +0100, Mark Brown wrote: > When resolving regulator-regulator supplies we ignore probe deferral > returns from regulator_dev_lookup() (such as are generated for DT when > we can see a supply is registered) and just fall back to the dummy > regulator if there are full constraints (as is the case for DT). This > means that probe deferral is broken for DT systems, fix that by paying > attention to -EPROBE_DEFER return codes like we do -ENODEV. > > A further patch will simplify this further, this is a minimal fix for > the specific issue. > > Reported-by: Sascha Hauer > Signed-off-by: Mark Brown > --- > > Tested with my famous "I need to leave the house right now so haven't > even tried building this yet" test plan - please let me know how this > works for you. Yes, this works as expected. Tested-by: Sascha Hauer Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |