Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic

[Lee Jones <lee.jones@linaro.org>]

On Wed, 30 Sep 2015, Johan Hovold wrote:

> On Tue, Sep 29, 2015 at 01:26:08PM +0200, Javier Martinez Canillas wrote:
> > The invoked functions already return zero on success or a negative
> > errno code so there is no need to open code the logic in the caller.
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> I do not consider this an improvement in any way and suggest this patch
> is dropped.

Sorry Johan, but I disagree.

> > ---
> >  drivers/mfd/lm3533-core.c | 12 ++----------
> >  1 file changed, 2 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> > index 643f3750e830..193ecee1fa7e 100644
> > --- a/drivers/mfd/lm3533-core.c
> > +++ b/drivers/mfd/lm3533-core.c
> > @@ -472,11 +472,7 @@ static int lm3533_device_setup(struct lm3533 *lm3533,
> >  	if (ret)
> >  		return ret;
> >  
> > -	ret = lm3533_set_boost_ovp(lm3533, pdata->boost_ovp);
> > -	if (ret)
> > -		return ret;
> > -
> > -	return 0;
> > +	return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp);
> 
> You're saving a few lines of code but instead introduce asymmetries and
> obscure the fact that the function returns zero on success.

There is no obfuscation here.  Functions normally return zero on
success and !zero on failure, it's what's expected.

I'm going to apply the patch.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog