From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755817AbbJAHRG (ORCPT ); Thu, 1 Oct 2015 03:17:06 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:35808 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753113AbbJAHRE (ORCPT ); Thu, 1 Oct 2015 03:17:04 -0400 Date: Thu, 1 Oct 2015 08:17:00 +0100 From: Lee Jones To: Johan Hovold Cc: Javier Martinez Canillas , linux-kernel@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic Message-ID: <20151001071700.GA3214@x1> References: <1443525968-30899-1-git-send-email-javier@osg.samsung.com> <1443525968-30899-9-git-send-email-javier@osg.samsung.com> <20150930210437.GF4284@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150930210437.GF4284@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015, Johan Hovold wrote: > On Tue, Sep 29, 2015 at 01:26:08PM +0200, Javier Martinez Canillas wrote: > > The invoked functions already return zero on success or a negative > > errno code so there is no need to open code the logic in the caller. > > > > Signed-off-by: Javier Martinez Canillas > > I do not consider this an improvement in any way and suggest this patch > is dropped. Sorry Johan, but I disagree. > > --- > > drivers/mfd/lm3533-core.c | 12 ++---------- > > 1 file changed, 2 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c > > index 643f3750e830..193ecee1fa7e 100644 > > --- a/drivers/mfd/lm3533-core.c > > +++ b/drivers/mfd/lm3533-core.c > > @@ -472,11 +472,7 @@ static int lm3533_device_setup(struct lm3533 *lm3533, > > if (ret) > > return ret; > > > > - ret = lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); > > - if (ret) > > - return ret; > > - > > - return 0; > > + return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); > > You're saving a few lines of code but instead introduce asymmetries and > obscure the fact that the function returns zero on success. There is no obfuscation here. Functions normally return zero on success and !zero on failure, it's what's expected. I'm going to apply the patch. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog