From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756080AbbJAHSV (ORCPT ); Thu, 1 Oct 2015 03:18:21 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:37017 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755488AbbJAHST (ORCPT ); Thu, 1 Oct 2015 03:18:19 -0400 Date: Thu, 1 Oct 2015 08:18:15 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, Samuel Ortiz Subject: Re: [PATCH 2/8] mfd: arizona: Remove unneded ret variable Message-ID: <20151001071815.GC3214@x1> References: <1443525968-30899-1-git-send-email-javier@osg.samsung.com> <1443525968-30899-3-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443525968-30899-3-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2015, Javier Martinez Canillas wrote: > The ret variable is not needed since is not used in the > function. Remove the variable and just return 0 instead. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/arizona-core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 44cfdbb295db..acf354875338 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -69,8 +69,6 @@ EXPORT_SYMBOL_GPL(arizona_clk32k_enable); > > int arizona_clk32k_disable(struct arizona *arizona) > { > - int ret = 0; > - > mutex_lock(&arizona->clk_lock); > > BUG_ON(arizona->clk32k_ref <= 0); > @@ -90,7 +88,7 @@ int arizona_clk32k_disable(struct arizona *arizona) > > mutex_unlock(&arizona->clk_lock); > > - return ret; > + return 0; > } > EXPORT_SYMBOL_GPL(arizona_clk32k_disable); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog