From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756107AbbJAHSv (ORCPT ); Thu, 1 Oct 2015 03:18:51 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:33884 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754388AbbJAHSt (ORCPT ); Thu, 1 Oct 2015 03:18:49 -0400 Date: Thu, 1 Oct 2015 08:18:46 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH 3/8] mfd: pcf50633: Remove unneded ret variable Message-ID: <20151001071846.GD3214@x1> References: <1443525968-30899-1-git-send-email-javier@osg.samsung.com> <1443525968-30899-4-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443525968-30899-4-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2015, Javier Martinez Canillas wrote: > The ret variable is not needed since is not used in the > function. Remove the variable and just return 0 instead. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/pcf50633-irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/pcf50633-irq.c b/drivers/mfd/pcf50633-irq.c > index 498286cbb530..71d43edf110c 100644 > --- a/drivers/mfd/pcf50633-irq.c > +++ b/drivers/mfd/pcf50633-irq.c > @@ -55,7 +55,7 @@ EXPORT_SYMBOL_GPL(pcf50633_free_irq); > static int __pcf50633_irq_mask_set(struct pcf50633 *pcf, int irq, u8 mask) > { > u8 reg, bit; > - int ret = 0, idx; > + int idx; > > idx = irq >> 3; > reg = PCF50633_REG_INT1M + idx; > @@ -72,7 +72,7 @@ static int __pcf50633_irq_mask_set(struct pcf50633 *pcf, int irq, u8 mask) > > mutex_unlock(&pcf->lock); > > - return ret; > + return 0; > } > > int pcf50633_irq_mask(struct pcf50633 *pcf, int irq) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog