From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 6/8] mfd: da903x: Simplify function return logic
Date: Thu, 1 Oct 2015 08:20:22 +0100 [thread overview]
Message-ID: <20151001072022.GG3214@x1> (raw)
In-Reply-To: <1443525968-30899-7-git-send-email-javier@osg.samsung.com>
On Tue, 29 Sep 2015, Javier Martinez Canillas wrote:
> The invoked function already returns zero on success or a negative
> errno code so there is no need to open code the logic in the caller.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mfd/da903x.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
> index ef7fe2ae2fa4..37e4426ef061 100644
> --- a/drivers/mfd/da903x.c
> +++ b/drivers/mfd/da903x.c
> @@ -532,11 +532,7 @@ static int da903x_probe(struct i2c_client *client,
> return ret;
> }
>
> - ret = da903x_add_subdevs(chip, pdata);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return da903x_add_subdevs(chip, pdata);
> }
>
> static int da903x_remove(struct i2c_client *client)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-10-01 7:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 11:26 [PATCH 0/8] mfd: Simplify return logic Javier Martinez Canillas
2015-09-29 11:26 ` [PATCH 1/8] mfd: htc-i2cpld: Remove unneded ret variable Javier Martinez Canillas
2015-10-01 7:17 ` Lee Jones
2015-09-29 11:26 ` [PATCH 2/8] mfd: arizona: " Javier Martinez Canillas
2015-09-29 11:24 ` Charles Keepax
2015-10-01 7:18 ` Lee Jones
2015-09-29 11:26 ` [PATCH 3/8] mfd: pcf50633: " Javier Martinez Canillas
2015-10-01 7:18 ` Lee Jones
2015-09-29 11:26 ` [PATCH 4/8] mfd: kempld-core: Simplify function return logic Javier Martinez Canillas
2015-10-01 7:19 ` Lee Jones
2015-09-29 11:26 ` [PATCH 5/8] mfd: rtsx: " Javier Martinez Canillas
2015-10-01 7:19 ` Lee Jones
2015-09-29 11:26 ` [PATCH 6/8] mfd: da903x: " Javier Martinez Canillas
2015-09-29 12:24 ` Opensource [Adam Thomson]
2015-10-01 7:20 ` Lee Jones [this message]
2015-09-29 11:26 ` [PATCH 7/8] mfd: da9052: " Javier Martinez Canillas
2015-09-29 12:24 ` Opensource [Adam Thomson]
2015-10-01 7:20 ` Lee Jones
2015-09-29 11:26 ` [PATCH 8/8] mfd: lm3533: " Javier Martinez Canillas
2015-09-30 21:04 ` Johan Hovold
2015-09-30 21:41 ` Javier Martinez Canillas
2015-09-30 21:55 ` Johan Hovold
2015-10-01 7:17 ` Lee Jones
2015-10-01 17:59 ` Johan Hovold
2015-10-01 7:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001072022.GG3214@x1 \
--to=lee.jones@linaro.org \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).