From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756228AbbJAHUc (ORCPT ); Thu, 1 Oct 2015 03:20:32 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:33668 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbbJAHU0 (ORCPT ); Thu, 1 Oct 2015 03:20:26 -0400 Date: Thu, 1 Oct 2015 08:20:22 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Support Opensource , Samuel Ortiz Subject: Re: [PATCH 6/8] mfd: da903x: Simplify function return logic Message-ID: <20151001072022.GG3214@x1> References: <1443525968-30899-1-git-send-email-javier@osg.samsung.com> <1443525968-30899-7-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443525968-30899-7-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2015, Javier Martinez Canillas wrote: > The invoked function already returns zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/da903x.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c > index ef7fe2ae2fa4..37e4426ef061 100644 > --- a/drivers/mfd/da903x.c > +++ b/drivers/mfd/da903x.c > @@ -532,11 +532,7 @@ static int da903x_probe(struct i2c_client *client, > return ret; > } > > - ret = da903x_add_subdevs(chip, pdata); > - if (ret) > - return ret; > - > - return 0; > + return da903x_add_subdevs(chip, pdata); > } > > static int da903x_remove(struct i2c_client *client) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog