From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756273AbbJAHUu (ORCPT ); Thu, 1 Oct 2015 03:20:50 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:37146 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbbJAHUs (ORCPT ); Thu, 1 Oct 2015 03:20:48 -0400 Date: Thu, 1 Oct 2015 08:20:44 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Support Opensource , Samuel Ortiz Subject: Re: [PATCH 7/8] mfd: da9052: Simplify function return logic Message-ID: <20151001072044.GH3214@x1> References: <1443525968-30899-1-git-send-email-javier@osg.samsung.com> <1443525968-30899-8-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443525968-30899-8-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2015, Javier Martinez Canillas wrote: > The invoked functions already return zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/da9052-i2c.c | 6 +----- > drivers/mfd/da9052-spi.c | 6 +----- > 2 files changed, 2 insertions(+), 10 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c > index 02887001e800..2697ffb08009 100644 > --- a/drivers/mfd/da9052-i2c.c > +++ b/drivers/mfd/da9052-i2c.c > @@ -174,11 +174,7 @@ static int da9052_i2c_probe(struct i2c_client *client, > return ret; > } > > - ret = da9052_device_init(da9052, id->driver_data); > - if (ret != 0) > - return ret; > - > - return 0; > + return da9052_device_init(da9052, id->driver_data); > } > > static int da9052_i2c_remove(struct i2c_client *client) > diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c > index b5de8a6856c0..0f5e2c2858c1 100644 > --- a/drivers/mfd/da9052-spi.c > +++ b/drivers/mfd/da9052-spi.c > @@ -56,11 +56,7 @@ static int da9052_spi_probe(struct spi_device *spi) > return ret; > } > > - ret = da9052_device_init(da9052, id->driver_data); > - if (ret != 0) > - return ret; > - > - return 0; > + return da9052_device_init(da9052, id->driver_data); > } > > static int da9052_spi_remove(struct spi_device *spi) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog