From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756363AbbJAHVI (ORCPT ); Thu, 1 Oct 2015 03:21:08 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:33480 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756332AbbJAHVG (ORCPT ); Thu, 1 Oct 2015 03:21:06 -0400 Date: Thu, 1 Oct 2015 08:21:01 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Samuel Ortiz Subject: Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic Message-ID: <20151001072101.GI3214@x1> References: <1443525968-30899-1-git-send-email-javier@osg.samsung.com> <1443525968-30899-9-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443525968-30899-9-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2015, Javier Martinez Canillas wrote: > The invoked functions already return zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/mfd/lm3533-core.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c > index 643f3750e830..193ecee1fa7e 100644 > --- a/drivers/mfd/lm3533-core.c > +++ b/drivers/mfd/lm3533-core.c > @@ -472,11 +472,7 @@ static int lm3533_device_setup(struct lm3533 *lm3533, > if (ret) > return ret; > > - ret = lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); > - if (ret) > - return ret; > - > - return 0; > + return lm3533_set_boost_ovp(lm3533, pdata->boost_ovp); > } > > static int lm3533_device_init(struct lm3533 *lm3533) > @@ -613,11 +609,7 @@ static int lm3533_i2c_probe(struct i2c_client *i2c, > lm3533->dev = &i2c->dev; > lm3533->irq = i2c->irq; > > - ret = lm3533_device_init(lm3533); > - if (ret) > - return ret; > - > - return 0; > + return lm3533_device_init(lm3533); > } > > static int lm3533_i2c_remove(struct i2c_client *i2c) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog