From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757116AbbJAUnB (ORCPT ); Thu, 1 Oct 2015 16:43:01 -0400 Received: from down.free-electrons.com ([37.187.137.238]:43714 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757054AbbJAUm4 (ORCPT ); Thu, 1 Oct 2015 16:42:56 -0400 Date: Thu, 1 Oct 2015 22:14:28 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] irqchip: sunxi-nmi: Use driver name instead of DT node name for identification Message-ID: <20151001201428.GO7104@lukather> References: <1443713629-17415-1-git-send-email-wens@csie.org> <1443713629-17415-2-git-send-email-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4eYdsOpNbj/aD8un" Content-Disposition: inline In-Reply-To: <1443713629-17415-2-git-send-email-wens@csie.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4eYdsOpNbj/aD8un Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Oct 01, 2015 at 11:33:48PM +0800, Chen-Yu Tsai wrote: > The device tree node name is typically "interrupt-controller", which is > rather useless when used in printk messages and irq chip names for > identification purposes. Use the driver name "sunxi-nmi" instead. >=20 > Signed-off-by: Chen-Yu Tsai > --- > drivers/irqchip/irq-sunxi-nmi.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-= nmi.c > index c143dd58410c..57e009917d2d 100644 > --- a/drivers/irqchip/irq-sunxi-nmi.c > +++ b/drivers/irqchip/irq-sunxi-nmi.c > @@ -21,6 +21,7 @@ > #include > =20 > #define SUNXI_NMI_SRC_TYPE_MASK 0x00000003 > +#define DRV_NAME "sunxi-nmi" > =20 > enum { > SUNXI_SRC_TYPE_LEVEL_LOW =3D 0, > @@ -130,22 +131,22 @@ static int __init sunxi_sc_nmi_irq_init(struct devi= ce_node *node, > =20 > domain =3D irq_domain_add_linear(node, 1, &irq_generic_chip_ops, NULL); > if (!domain) { > - pr_err("%s: Could not register interrupt domain.\n", node->name); > + pr_err("%s: Could not register interrupt domain.\n", DRV_NAME); > return -ENOMEM; > } > =20 > - ret =3D irq_alloc_domain_generic_chips(domain, 1, 2, node->name, > + ret =3D irq_alloc_domain_generic_chips(domain, 1, 2, DRV_NAME, > handle_fasteoi_irq, clr, 0, > IRQ_GC_INIT_MASK_CACHE); > if (ret) { > pr_err("%s: Could not allocate generic interrupt chip.\n", > - node->name); > + DRV_NAME); > goto fail_irqd_remove; > } > =20 > irq =3D irq_of_parse_and_map(node, 0); > if (irq <=3D 0) { > - pr_err("%s: unable to parse irq\n", node->name); > + pr_err("%s: unable to parse irq\n", DRV_NAME); > ret =3D -EINVAL; > goto fail_irqd_remove; > } > @@ -153,7 +154,7 @@ static int __init sunxi_sc_nmi_irq_init(struct device= _node *node, > gc =3D irq_get_domain_generic_chip(domain, 0); > gc->reg_base =3D of_iomap(node, 0); > if (!gc->reg_base) { > - pr_err("%s: unable to map resource\n", node->name); > + pr_err("%s: unable to map resource\n", DRV_NAME); All the pr_err changes can even be replaced by defining pr_fmt. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --4eYdsOpNbj/aD8un Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDZQkAAoJEBx+YmzsjxAgQPEQAIxrljtFy/Gww/DMc3N0x3fc x9fbKLZGLGiQfTQkHPy9tZsNk+aCEOQ6bSjzOOx0jTjI582ZW91t8gvmSBxMFhkx t0Nf00s3xdnWwP7Gy90t+NsfRtw4reG9bVDbuVrkCF/uRX8HSjT4UM99LqF3MB1L 3spGKlX4K1XPa35jvV1NLh4t/QYopeWhTC/sMKJwPu8CgKvi6tJW3Ahoat7bav+K QHhmCtIYlybAeG8npFYjq5ii2F1A0pXB5TnQhwm4eVzwJdqmkiu9bPTDvtj53aNK kPr9iydUqvzu1XEyXaBv72pH7UHQX9OkZUFA/T+8H76hTU/pjGmwTgVjiM8AOl9c iZ+DkkVbUf1NASHdsmcO3pvR/QLZNpsHQKGglMYXXJAfml7uZrLvgntZ0Wsr2tJY tS3sc3SL+0w2MsuQCEwUcGcTWedP73WePuGTYhKnWaoJ70yJGlmxCwI9ESUp+HlU GRA2x3UK7sqnhc6XVq0xjn+IYxS/ZkfefxUC1TlfSv44pJVjPwi4M7GWkIa9qbRE Q/F80dfgj53rq/78nU7o2vru46U2dU27BzjqQYGUfaNAHaQanHb0lh1tUwHqBkpC Ir9kOFmXtCYBKq7OKaJJgGsstK/XX/QutWSnW9gncvHoSBsOlRv1FLC4eICJizCD FzBik/eB5YWpgDMBMEUm =jF0s -----END PGP SIGNATURE----- --4eYdsOpNbj/aD8un--