From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751166AbbJAWE7 (ORCPT ); Thu, 1 Oct 2015 18:04:59 -0400 Received: from mga11.intel.com ([192.55.52.93]:28167 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbbJAWE6 (ORCPT ); Thu, 1 Oct 2015 18:04:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,619,1437462000"; d="scan'208";a="817524580" Date: Thu, 1 Oct 2015 15:04:57 -0700 From: Andi Kleen To: Andi Kleen Cc: Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: Fix thermal throttling reporting after kexec Message-ID: <20151001220457.GD26924@tassilo.jf.intel.com> References: <1443125443-24691-1-git-send-email-andi@firstfloor.org> <20151001172737.GC26924@tassilo.jf.intel.com> <20151001214959.GF12732@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151001214959.GF12732@two.firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 01, 2015 at 11:50:00PM +0200, Andi Kleen wrote: > > I see it under the correctness aspect. Mop up before you shut down. > > Ok. I suspect if you want to clean up all registers there's much more > to do. > > BTW there's a small danger in it: if we ever crash accessing on > of those registers panic may end up looping. I thought more about it. Since this is per logical CPU state the cleanup cannot be done in a normal shutdown callback (which only runs on one CPU), but needs some kind of global IPI/NMI. IPI could deadlock, so it would need to be NMI. KVM already has one, but would need to re-organize that into first into a generic callback infrastructure. I don't think so much change is worth it for this one somewhat dubious case. NMI code is also tricky and it's probably better to keep the shut down paths as simple and reliable as possible. Do you agree? -Andi -- ak@linux.intel.com -- Speaking for myself only