From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751349AbbJBDfZ (ORCPT ); Thu, 1 Oct 2015 23:35:25 -0400 Received: from mail-bl2on0144.outbound.protection.outlook.com ([65.55.169.144]:21585 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751115AbbJBDfX (ORCPT ); Thu, 1 Oct 2015 23:35:23 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Date: Thu, 1 Oct 2015 22:35:06 -0500 From: Scott Wood To: CC: , , , , , , , , Subject: Re: [v5, 2/6] fsl/fman: Add FMan support Message-ID: <20151002033506.GA8067@home.buserror.net> References: <1443085838-7539-1-git-send-email-igal.liberman@freescale.com> <1443085838-7539-3-git-send-email-igal.liberman@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1443085838-7539-3-git-send-email-igal.liberman@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: BY2PR01CA0078.prod.exchangelabs.com (25.163.25.46) To BY1PR03MB1483.namprd03.prod.outlook.com (25.162.210.141) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1483;2:AXVMmMc8ySURGgCl9rOX0zP7xxEqM+5AxjDdUAzMr7DUpnCeVV+xBqRsjAkAczl96TiMvB7o7eC5SY2+NxJ320glWPIc96ROLrMdjX6J5WX3dAU55xNQmBtaZsQFu9EDnc1wm/3DYkVaniz5D90pg+TZ3Sw8zGz7MyEmznJkFTs=;3:lD6RIivEHrhnA2HI9Px8gw299vxHTbP1bh5E1zBW39zoKGxBA7lh48Xe0OZ5lncSbm1KqI2q3N2DzdJXnU21qsaEViXHIHutM79DCibAnU1eRqCmjpJ+DKyuM68gSiWo50rUmKu8JSPipubNhae2Iw==;25:0kCJ+SVb+LpfDjn9lGIEOEYRMKG3M6GiDax8DcGAWbyuKQlufTTTOyQBozgFikQLbD+BO1w8QktU2ILZVOXd1NWfC8x0+9OY1F28OHWHDBG01hvtagtXpRQMRE7HUizztqYWeYThx9XegNuoa8p7zgx5ZEmmnehOITJVbW1sx9tbBvGKiyXGEohCnZPBnpxRKihbpob0KsSGwz/wskQN71E8zS6TlCwrgEYtQsjq3c8y1nfJnm0Uieaktn6xF6W7UwOf3DdKskpOq4+G2btnTQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1483; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1483;20:TxhQTEWFAk2R9lMhWsfWlDzVGE2QVqkzZ7N68zwAiUGnv1E024G2zr2DwC1ldmeobyEdmLxCe3X8pyTCjjhDYM4JFmpQtfj13z4P4pQQ/tRoTPLlCAJOfB4aVe6wfTkEaIeRSaxO/5IXLBxdUHS7o/W1NNpIk7EHWAa9Uxx7tIhGYj/QkvEQ0Ux60EOinUbvwDYIRl5tN/+VfvmmiaE9zN1sTUuKaShR4BOe4rsGv8T+XprpfjTN91sAI4MesKEewXKfpxoM3J+USpcqtKlGrKIiU/eU9pedx2mAf12EDuisGUv1i5Ps2lZfV+5btCyljKefAoVANVcMZUbLLBdEffCQji2siiMk1ZCseSUFtBRm+5it1H0PMb9SXiE+vV2BzGr+omoT/sWAYpUvjIKxzsEDI49WMMP5WBlGEZzGHcjKzErhhF76x0wD5IvdKx6KcW3+xSRhZOxA7dKqNjfNUKlC3o20id5/Vtvyh0YR0rZux+byPKZw0f5eNykU7QfQ;4:UCOB4ETF1qb/abaO+zUWG0WzdRRwqQzxkWSwKZHTUny4tORg4crQ2rSOy3yRXt9MYq6BRpael6CeWywFKjmCEWmPyOhyntRQsPwwGRFcAgZxbThhx46EaTys3U8pcVY3iiNzqAs4doZAVHCyn4ef1pETyInVY7FULVPifz/i5DBRmbBAnZiIM2K04oz9/zfjezQuOk5m3r6IDfZKK5pCjKgG0og8ktL0UKGtMZisxWYKrjKcTW2o4Npp6xa/ejmBpIp+T3MtUQYVPlcX8+B25AJP03HLcPyRu5IAkBqB41yFiGEcvq+89ZnPVs/3QktdY80FNs/z2AdWEZx4I+0vINN3wPr6Un51ayR2fS4v0b8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:BY1PR03MB1483;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1483; X-Forefront-PRVS: 0717E25089 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(199003)(189002)(101416001)(66066001)(5001960100002)(46406003)(23726002)(40100003)(50986999)(2950100001)(87976001)(5007970100001)(19580405001)(69596002)(97756001)(19580395003)(5001860100001)(46102003)(81156007)(97736004)(122386002)(64706001)(47776003)(50466002)(4001540100001)(2371004)(92566002)(76176999)(5004730100002)(53416004)(4001350100001)(2351001)(77156002)(68736005)(5008740100001)(106356001)(5001830100001)(54356999)(86362001)(62966003)(83506001)(4001450100002)(189998001)(105586002)(110136002)(33656002)(42186005)(77096005);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1483;H:home.buserror.net;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY1PR03MB1483;23:QyqyypsTgkmBnSubzMNfqi0HP7KAJQcg1AbfL2TLF?= =?us-ascii?Q?WYqwjKWvPilDyMOOAYXlWK7h/rjpYJS38ZCTNYQ8uw8TPzW51aVdWZaB4eyQ?= =?us-ascii?Q?8HeLoYK6bWLzem7DmXJUPR6sNa6I3uOMFbf61kReN9dLYvpokjK5VDRSskAi?= =?us-ascii?Q?rflndCJGArpqKxJkXrjZp4E2tvqGZ7PITtOMQc1GvgKf2yEvDvmz+nLclxTD?= =?us-ascii?Q?YB9E4orGEziSridDrCkDYOtzKhpMD0Sl7lD+WxpU6gHsdYK7mnLGgTs3BxT+?= =?us-ascii?Q?vOgcI0lG6xXk2PdlLWRTn/mm0kIP4lr6/13pEfIUYNHHFgzj1XzhoZOsajAn?= =?us-ascii?Q?W+rU/VeBceamY/qZB8PrFnaV/u+z3hs+aal4eZb8Fr5lXJkzrGqY/ILrc98b?= =?us-ascii?Q?LYSWm0RhWRyS+vtgZIWQ1DzxS1Xp0q4h35qUCVEwfP32URxZW264TSK3DoqT?= =?us-ascii?Q?fy6xRjFx5JlzpFV2eoUJWp1vAMdfVRSp8J+gIU1nYEk3uVcGfAgLMupvYpyS?= =?us-ascii?Q?gY7FB/wj3VEjz+bRtdQJyNR68et41QpuvRD2vjXrW0SM1OJzKoXneHIz1orP?= =?us-ascii?Q?W6aOUpE3DnUL+pS0cQXGzX8Ocd8ezt4AgrQ1LyMaTTGWCS4WIt5mBkdKmkQm?= =?us-ascii?Q?Qm2v4Pcxg0BHKzOOGQ4x0nEabIu3z+io3rFAMWmnrds/bZS+TktMnsE9DOyj?= =?us-ascii?Q?rIp6+TpWsiqUkFNoTZrbL7eNc3R78+8Qbzh2enDHMnOdOkdDaqU0aBn1c9rZ?= =?us-ascii?Q?7W6dSDnlTA3qk2rXMNqCW0c89m9rTGlZrUAJY38CNSuIALZlOkS0zh2oLWWu?= =?us-ascii?Q?wuwE3wdX7drswCSZdS9CXZaBK2RcTMyEpDnm47Cqj8Yepz3SFItaoos5TmVd?= =?us-ascii?Q?K4f33LV2M5n8T5SuoH4CDfna2HHgAm1+B0Cl4pOi+bKmqGBnQgZ24rzco1BB?= =?us-ascii?Q?puE+hy7PG3+C+OYPPMioRtdiZgzCIeCvNXcvVpZrlPZnBD3IYlxxDZEvs8fj?= =?us-ascii?Q?mFDUQDlP1GILHX8glQix9IiLu2czkLUIBL0xOCtKzn5Ey93SLyAWOLtjSLpQ?= =?us-ascii?Q?cTCwhaWyx3qQ+YYF+XVJUYJIpvm89s7ouMc9JAu9gwa8pXVbjeNPK3TRRa2d?= =?us-ascii?Q?Cms6IHieWn5j2VkUR5AXb1cWbm3ZfXiwNFLi+X0nIXVIdHgHJ0FCdjzkHyfb?= =?us-ascii?Q?flxMj8X4p6lc0fPhnU/m3jbJNECTUGZ72Nk8C/0io02C4W6VNfeyGqHGADdC?= =?us-ascii?Q?vHxDA96gXDYawLMZyStSZAcehvHSGSsYzRSvL/IhgbD90L8sMbZ4gxejDdjh?= =?us-ascii?Q?C71fA+NZH4Bqfdoltc+sEuJyKr3nZ8riJQmgUij2Ojv?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1483;5:7h+A4zE/j0vKInNxJspgmy5GHyHfTrwt7J9Fk3uE0ux+Bl7T2/WYXcmEtqAIoDqK7HNOl4RXe/EqWszgMsiHf5k3PtqFSWtuVwby44QKTrOODRCIjh0MSMizSTEk0/+wHOdepmFlC0kCN6Nxk/FELg==;24:tSaxBjHsSXlAwHbYedqmx+Npa2TqyKI1blkm6GNry4i9xuqmL0XTAkEAzsy6TVdEyFA/y/9tVJDEB16x6a7U0uD844aoZc4dTBRf+03w/5Y=;20:QePTSwijE0B1oZjVtrjEWhof1IRDYpgHv4SQlQ3/gIsp/ytNMNR9whVuD6quDFTLPKa04uM2Jb0f3aVFP2vQfQ== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2015 03:35:19.3347 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1483 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 12:10:34PM +0300, igal.liberman@freescale.com wrote: > +int fman_get_rx_extra_headroom(void) > +{ > + static bool fm_check_rx_extra_headroom; > + > + if (!fm_check_rx_extra_headroom) { > + if (fsl_fm_rx_extra_headroom > FSL_FM_RX_EXTRA_HEADROOM_MAX || > + fsl_fm_rx_extra_headroom < FSL_FM_RX_EXTRA_HEADROOM_MIN) { > + pr_warn("Invalid fsl_fm_rx_extra_headroom value (%d) in bootargs, valid range is %d-%d. Falling back to the default (%d)\n", > + fsl_fm_rx_extra_headroom, > + FSL_FM_RX_EXTRA_HEADROOM_MIN, > + FSL_FM_RX_EXTRA_HEADROOM_MAX, > + FSL_FM_RX_EXTRA_HEADROOM); > + fsl_fm_rx_extra_headroom = FSL_FM_RX_EXTRA_HEADROOM; > + } > + > + fsl_fm_rx_extra_headroom = true; I think you mean "fm_check_rx_extra_headroom = true". > + fsl_fm_rx_extra_headroom = ALIGN(fsl_fm_rx_extra_headroom, 16); > + } > + > + return fsl_fm_rx_extra_headroom; > +} > +EXPORT_SYMBOL(fman_get_rx_extra_headroom); Please just check things like this once during module init. Init-on-first-use is unnecessarily complicated, and race-prone. -Scott