From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758AbbJBNRB (ORCPT ); Fri, 2 Oct 2015 09:17:01 -0400 Received: from down.free-electrons.com ([37.187.137.238]:55099 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752723AbbJBNQ7 convert rfc822-to-8bit (ORCPT ); Fri, 2 Oct 2015 09:16:59 -0400 Date: Fri, 2 Oct 2015 15:16:43 +0200 From: Alexandre Belloni To: Sudeep Holla Cc: Linus Walleij , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Thomas Gleixner , "Rafael J. Wysocki" , Alessandro Zummo , "rtc-linux@googlegroups.com" Subject: Re: [PATCH 01/17] rtc: pl031: remove misuse of IRQF_NO_SUSPEND flag Message-ID: <20151002131643.GD10444@piout.net> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-2-git-send-email-sudeep.holla@arm.com> <560E603E.8080603@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <560E603E.8080603@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/2015 at 11:45:18 +0100, Sudeep Holla wrote : > > > On 02/10/15 11:40, Linus Walleij wrote: > >On Mon, Sep 21, 2015 at 8:46 AM, Sudeep Holla wrote: > > > >>The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > >>be left enabled so as to allow them to work as expected during the > >>suspend-resume cycle, but doesn't guarantee that it will wake the system > >>from a suspended state, enable_irq_wake is recommended to be used for > >>the wakeup. > >> > >>This patch removes the use of IRQF_NO_SUSPEND flags and uses newly > >>introduce PM wakeup APIs dev_pm_{set,clear}_wake_irq. > >> > >>Cc: Linus Walleij > >>Cc: Alessandro Zummo > >>Cc: Alexandre Belloni > >>Cc: rtc-linux@googlegroups.com > >>Signed-off-by: Sudeep Holla > > > >Looks correct to me. > >Acked-by: Linus Walleij > > > > Thanks, while you are at it, do you know what interrupt stv2_pl031 > shares so that I can fix the TODO in the comment or the code(whichever > applicable). > So that you know, I'm planning to apply them this weekend, I couldn't find time to do it before. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com