From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753128AbbJBR3q (ORCPT ); Fri, 2 Oct 2015 13:29:46 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37189 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752568AbbJBR3p (ORCPT ); Fri, 2 Oct 2015 13:29:45 -0400 Date: Fri, 2 Oct 2015 12:29:39 -0500 From: Felipe Balbi To: Peter Senna Tschudin CC: , , , , , , , Subject: Re: [PATCH 01/14] RFC: usb/host/fotg210: Fix coding style issues Message-ID: <20151002172939.GL5552@saruman.tx.rr.com> Reply-To: References: <20150915165002.GP19948@saruman.tx.rr.com> <1442847678-7970-1-git-send-email-peter.senna@gmail.com> <1442847678-7970-2-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f54savKjS/tSNRaU" Content-Disposition: inline In-Reply-To: <1442847678-7970-2-git-send-email-peter.senna@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --f54savKjS/tSNRaU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2015 at 05:01:05PM +0200, Peter Senna Tschudin wrote: > This patch fix coding style issues reported by checkpatch that do not > change semantics of the code. >=20 > Signed-off-by: Peter Senna Tschudin > --- > drivers/usb/host/fotg210-hcd.c | 1248 +++++++++++++++++-----------------= ------ > drivers/usb/host/fotg210.h | 36 +- > 2 files changed, 558 insertions(+), 726 deletions(-) >=20 > diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hc= d.c > index 000ed80..48eac34 100644 > --- a/drivers/usb/host/fotg210-hcd.c > +++ b/drivers/usb/host/fotg210-hcd.c > @@ -50,32 +50,30 @@ > #include > #include > =20 > -/*----------------------------------------------------------------------= ---*/ > #define DRIVER_AUTHOR "Yuan-Hsin Chen" > #define DRIVER_DESC "FOTG210 Host Controller (EHCI) Driver" > - > -static const char hcd_name[] =3D "fotg210_hcd"; > +static const char hcd_name[] =3D "fotg210_hcd"; > =20 > #undef FOTG210_URB_TRACE > - > #define FOTG210_STATS > =20 > /* magic numbers that can affect system performance */ > -#define FOTG210_TUNE_CERR 3 /* 0-3 qtd retries; 0 =3D=3D don't stop */ > -#define FOTG210_TUNE_RL_HS 4 /* nak throttle; see 4.9 */ > -#define FOTG210_TUNE_RL_TT 0 > -#define FOTG210_TUNE_MULT_HS 1 /* 1-3 transactions/uframe; 4.10.3 */ > -#define FOTG210_TUNE_MULT_TT 1 > +#define FOTG210_TUNE_CERR 3 /* 0-3 qtd retries; 0 =3D=3D don't stop */ > +#define FOTG210_TUNE_RL_HS 4 /* nak throttle; see 4.9 */ > +#define FOTG210_TUNE_RL_TT 0 > +#define FOTG210_TUNE_MULT_HS 1 /* 1-3 transactions/uframe; 4.10.3 */ > +#define FOTG210_TUNE_MULT_TT 1 > + > /* > - * Some drivers think it's safe to schedule isochronous transfers more t= han > - * 256 ms into the future (partly as a result of an old bug in the sched= uling > + * Some drivers think it's safe to schedule isochronous transfers more t= han 256 > + * ms into the future (partly as a result of an old bug in the scheduling > * code). In an attempt to avoid trouble, we will use a minimum schedul= ing > * length of 512 frames instead of 256. > */ > -#define FOTG210_TUNE_FLS 1 /* (medium) 512-frame schedule */ > +#define FOTG210_TUNE_FLS 1 /* (medium) 512-frame schedule */ > =20 > /* Initial IRQ latency: faster than hw default */ > -static int log2_irq_thresh; /* 0 to 6 */ > +static int log2_irq_thresh; /* 0 to 6 */ > module_param(log2_irq_thresh, int, S_IRUGO); > MODULE_PARM_DESC(log2_irq_thresh, "log2 IRQ latency, 1-64 microframes"); > =20 > @@ -89,66 +87,57 @@ static unsigned int hird; > module_param(hird, int, S_IRUGO); > MODULE_PARM_DESC(hird, "host initiated resume duration, +1 for each 75us= "); > =20 > -#define INTR_MASK (STS_IAA | STS_FATAL | STS_PCD | STS_ERR | STS_INT) > +#define INTR_MASK (STS_IAA | STS_FATAL | STS_PCD | STS_ERR | STS_INT) > =20 > #include "fotg210.h" > =20 > -/*----------------------------------------------------------------------= ---*/ > - > #define fotg210_dbg(fotg210, fmt, args...) \ > - dev_dbg(fotg210_to_hcd(fotg210)->self.controller , fmt , ## args) > + dev_dbg(fotg210_to_hcd(fotg210)->self.controller, fmt, ## args) > #define fotg210_err(fotg210, fmt, args...) \ > - dev_err(fotg210_to_hcd(fotg210)->self.controller , fmt , ## args) > + dev_err(fotg210_to_hcd(fotg210)->self.controller, fmt, ## args) > #define fotg210_info(fotg210, fmt, args...) \ > - dev_info(fotg210_to_hcd(fotg210)->self.controller , fmt , ## args) > + dev_info(fotg210_to_hcd(fotg210)->self.controller, fmt, ## args) > #define fotg210_warn(fotg210, fmt, args...) \ > - dev_warn(fotg210_to_hcd(fotg210)->self.controller , fmt , ## args) > + dev_warn(fotg210_to_hcd(fotg210)->self.controller, fmt, ## args) > =20 > -/* check the values in the HCSPARAMS register > - * (host controller _Structural_ parameters) > - * see EHCI spec, Table 2-4 for each value > +/* check the values in the HCSPARAMS register (host controller _Structur= al_ if you're fixing coding style issues, you might as well go ahead and fix th= is comment style too: /* * check the values .... -- balbi --f54savKjS/tSNRaU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWDr8DAAoJEIaOsuA1yqREPT0P/3r6RIAIVdoBfDKMx2JGy9Wu QS6RHC/u7p/m/XoSC62WkRUAo6F/u5oc/4/w9v/o/vixeVWL9JWxPHPymAImh9uy tmfeDYnSRTXKjAZ8EtGE1jWM+A50FIh0Y6itsCR9cAvVOLcZf2ED177UQ23jub0i 58d8PeZX2V83N+BYmI203yOvnoKP1a3H64Qi+hf3ipvgaB+PiVi2Lt5hZkX+4BJu kGQ+ZjDMCpAqwXjmnd4xowiEptQX7ts1UG/ciHeOK7/nIxARwCr6zHs3x0MKXLVR Q98D4GiF3VkRBjP7d6m5IYCRFX78ShnxA93eWhwe7rsDrvDrrMxKDl06WAXI/1g2 M6WDC8Xq5XYOqs+qqTD1fjU3JRuxZFxoqRZQqD6oLPh0I3Mm6o8cSksPq2x1YsAz H7rbu13ID26HjVRfNVZ22sbmafL6NgWeu54xBJmQCf2/+MvceNF9RWRnqp+DVbM2 WAClst8gtmQrOoVbznTa03x9BBMoJppV4MVrEyADc4/MV1uF30o22GevOApZyDCc MoXEQ/4RygOVCeNtY63MbQn7f31b6QS9iyyuZAWDnLAnmPEA7J/BW0r0BtLAXvIc LERmFZuKOK8+6V3MPGzzC0xi4CI+cmCB2vcKf8LN2cPkOLUmx32+Egd3J+uAJZij E4nQrvN3u1ZpDCOgNu5P =nz62 -----END PGP SIGNATURE----- --f54savKjS/tSNRaU--