From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
Luis de Bethencourt <luisbg@osg.samsung.com>,
Hans de Goede <hdegoede@redhat.com>,
Linus Walleij <linus.walleij@linaro.org>,
Scott Branden <sbranden@broadcom.com>,
Robin Gong <b38343@freescale.com>,
Lee Jones <lee.jones@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Matt Ranostay <mranostay@gmail.com>,
linux-input@vger.kernel.org, Frank Li <Frank.Li@freescale.com>
Subject: Re: [PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST
Date: Fri, 2 Oct 2015 10:53:42 -0700 [thread overview]
Message-ID: <20151002175342.GF8437@dtor-ws> (raw)
In-Reply-To: <1443797278-9052-1-git-send-email-javier@osg.samsung.com>
On Fri, Oct 02, 2015 at 04:47:58PM +0200, Javier Martinez Canillas wrote:
> The driver depends on GOLDFISH but there isn't a build dependency
> so it's a good idea to allow the driver to be built even if that
> option is disabled, if the COMPILE_TEST option is enabled.
>
> That way, the driver can be built with a config generated by make
> allyesconfig and can be checked if a patch would break the build.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
Applied, thank you.
> ---
>
> drivers/input/keyboard/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 2e80107ff630..ddd8148d51d7 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -516,7 +516,7 @@ config KEYBOARD_SAMSUNG
> module will be called samsung-keypad.
>
> config KEYBOARD_GOLDFISH_EVENTS
> - depends on GOLDFISH
> + depends on GOLDFISH || COMPILE_TEST
> tristate "Generic Input Event device for Goldfish"
> help
> Say Y here to get an input event device for the Goldfish virtual
> --
> 2.4.3
>
--
Dmitry
prev parent reply other threads:[~2015-10-02 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 14:47 [PATCH] Input: goldfish - Allow compile the driver with COMPILE_TEST Javier Martinez Canillas
2015-10-02 17:53 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002175342.GF8437@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=Frank.Li@freescale.com \
--cc=b38343@freescale.com \
--cc=geert@linux-m68k.org \
--cc=hdegoede@redhat.com \
--cc=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=mranostay@gmail.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).