From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753195AbbJBSPf (ORCPT <rfc822;w@1wt.eu>);
	Fri, 2 Oct 2015 14:15:35 -0400
Received: from mail-pa0-f47.google.com ([209.85.220.47]:34758 "EHLO
	mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751919AbbJBSPe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 2 Oct 2015 14:15:34 -0400
Date: Fri, 2 Oct 2015 11:15:31 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Heiko =?iso-8859-1?Q?St=FCbner?= <heiko.stuebner@bq.com>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
        linux-kernel@vger.kernel.org, Jingoo Han <jg1.han@samsung.com>,
        Dirk Behme <dirk.behme@de.bosch.com>,
        Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        linux-input@vger.kernel.org
Subject: Re: [PATCH 06/18] Input: zforce - simplify function return logic
Message-ID: <20151002181531.GK8437@dtor-ws>
References: <1443793229-22363-1-git-send-email-javier@osg.samsung.com>
 <1443793229-22363-7-git-send-email-javier@osg.samsung.com>
 <9921230.rYIRnnZOQ1@diego>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9921230.rYIRnnZOQ1@diego>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 02, 2015 at 03:54:51PM +0200, Heiko Stübner wrote:
> Am Freitag, 2. Oktober 2015, 15:40:17 schrieb Javier Martinez Canillas:
> > The invoked function already returns zero on success or a negative
> > errno code so there is no need to open code the logic in the caller.
> > 
> > This also fixes the following make coccicheck warning:
> > 
> > end returns can be simplified and declaration on line 602 can be dropped
> > 
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> I wonder what let me make that decision ... probably copy'n'paste from my auo-
> pixcir driver ... but how that got into this one is still a mystery to me ;-)
> anyway
> 
> Reviewed-by: Heiko Stuebner <heiko.stuebner@bq.com>

Applied, thank you.

> 
> 
> > ---
> > 
> >  drivers/input/touchscreen/zforce_ts.c | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
> > 
> > diff --git a/drivers/input/touchscreen/zforce_ts.c
> > b/drivers/input/touchscreen/zforce_ts.c index 781d0f83050a..9bbadaaf6bc3
> > 100644
> > --- a/drivers/input/touchscreen/zforce_ts.c
> > +++ b/drivers/input/touchscreen/zforce_ts.c
> > @@ -599,13 +599,8 @@ static irqreturn_t zforce_irq_thread(int irq, void
> > *dev_id) static int zforce_input_open(struct input_dev *dev)
> >  {
> >  	struct zforce_ts *ts = input_get_drvdata(dev);
> > -	int ret;
> > 
> > -	ret = zforce_start(ts);
> > -	if (ret)
> > -		return ret;
> > -
> > -	return 0;
> > +	return zforce_start(ts);
> >  }
> > 
> >  static void zforce_input_close(struct input_dev *dev)
> 

-- 
Dmitry