From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753851AbbJBSVi (ORCPT ); Fri, 2 Oct 2015 14:21:38 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60232 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068AbbJBSVg (ORCPT ); Fri, 2 Oct 2015 14:21:36 -0400 Date: Fri, 2 Oct 2015 11:21:33 -0700 From: Stephen Boyd To: Suman Anna Cc: Tero Kristo , Mike Turquette , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: ti: dflt: fix enable_reg validity check Message-ID: <20151002182133.GO12338@codeaurora.org> References: <1443566267-50225-1-git-send-email-s-anna@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443566267-50225-1-git-send-email-s-anna@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/29, Suman Anna wrote: > diff --git a/drivers/clk/ti/clkt_dflt.c b/drivers/clk/ti/clkt_dflt.c > index 90d7d8a21c49..1ddc288fce4e 100644 > --- a/drivers/clk/ti/clkt_dflt.c > +++ b/drivers/clk/ti/clkt_dflt.c > @@ -222,7 +222,7 @@ int omap2_dflt_clk_enable(struct clk_hw *hw) > } > } > > - if (unlikely(!clk->enable_reg)) { > + if (unlikely(IS_ERR(clk->enable_reg))) { IS_ERR() already has an unlikely inside it, so the unlikely is redundant here. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project