public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	"Nuno Gonçalves" <nunojpg@gmail.com>,
	"Miroslav Lichvar" <mlichvar@redhat.com>,
	"Prarit Bhargava" <prarit@redhat.com>,
	"Richard Cochran" <richardcochran@gmail.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Shuah Khan" <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v3] kselftest: timers: Add adjtick test to validate adjtimex() tick adjustments
Date: Sat, 3 Oct 2015 09:47:33 +0200	[thread overview]
Message-ID: <20151003074733.GB25143@gmail.com> (raw)
In-Reply-To: <1443826323-24148-1-git-send-email-john.stultz@linaro.org>


* John Stultz <john.stultz@linaro.org> wrote:

> Recently an issue was reported that was difficult to detect except
> by tweaking the adjtimex tick value, and noticing how quickly the
> adjustment took to be made:
> 	https://lkml.org/lkml/2015/9/1/488
> 
> Thus this patch introduces a new test which manipulates the adjtimex
> tick value and validates the results are what we expect.

So I tried to run this:

triton:~/tip/tools/testing/selftests/timers> ./adjtick 
systick: 10000
Estimating tick (act: 9000 usec, -100000 ppm): 10000 usec, 1 ppmWARNING: Unexpected adjtimex return values, make sure ntpd is not running. triton:~/tip/tools/testing/selftests/timers> 

note the weird placement of the warning, and there's also no newline at the end.

It would also be nice to print out roughly how long the test will take - since it 
runs longer than 1-2 seconds.

Thanks,

	Ingo

      reply	other threads:[~2015-10-03  7:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 22:52 [PATCH v3] kselftest: timers: Add adjtick test to validate adjtimex() tick adjustments John Stultz
2015-10-03  7:47 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151003074733.GB25143@gmail.com \
    --to=mingo@kernel.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlichvar@redhat.com \
    --cc=nunojpg@gmail.com \
    --cc=prarit@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=shuahkh@osg.samsung.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox