From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbbJCHri (ORCPT ); Sat, 3 Oct 2015 03:47:38 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:35746 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbbJCHrh (ORCPT ); Sat, 3 Oct 2015 03:47:37 -0400 Date: Sat, 3 Oct 2015 09:47:33 +0200 From: Ingo Molnar To: John Stultz Cc: linux-kernel@vger.kernel.org, Nuno =?iso-8859-1?Q?Gon=E7alves?= , Miroslav Lichvar , Prarit Bhargava , Richard Cochran , Thomas Gleixner , Shuah Khan Subject: Re: [PATCH v3] kselftest: timers: Add adjtick test to validate adjtimex() tick adjustments Message-ID: <20151003074733.GB25143@gmail.com> References: <1443826323-24148-1-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443826323-24148-1-git-send-email-john.stultz@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * John Stultz wrote: > Recently an issue was reported that was difficult to detect except > by tweaking the adjtimex tick value, and noticing how quickly the > adjustment took to be made: > https://lkml.org/lkml/2015/9/1/488 > > Thus this patch introduces a new test which manipulates the adjtimex > tick value and validates the results are what we expect. So I tried to run this: triton:~/tip/tools/testing/selftests/timers> ./adjtick systick: 10000 Estimating tick (act: 9000 usec, -100000 ppm): 10000 usec, 1 ppmWARNING: Unexpected adjtimex return values, make sure ntpd is not running. triton:~/tip/tools/testing/selftests/timers> note the weird placement of the warning, and there's also no newline at the end. It would also be nice to print out roughly how long the test will take - since it runs longer than 1-2 seconds. Thanks, Ingo