From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752053AbbJCIY5 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 3 Oct 2015 04:24:57 -0400
Received: from mail-wi0-f177.google.com ([209.85.212.177]:34505 "EHLO
	mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751911AbbJCIYx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 3 Oct 2015 04:24:53 -0400
Date: Sat, 3 Oct 2015 10:24:48 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: linux-kernel@vger.kernel.org, Alexei Starovoitov <ast@plumgrid.com>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] ebpf, events: make it actually more configurable
Message-ID: <20151003082448.GA27061@gmail.com>
References: <a0cfcb14b6aefee716ff34f3829f7d17948d5a2e.1443799500.git.daniel@iogearbox.net>
 <20151003063715.GA22713@gmail.com>
 <560F86FB.3070200@iogearbox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <560F86FB.3070200@iogearbox.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Daniel Borkmann <daniel@iogearbox.net> wrote:

> On 10/03/2015 08:37 AM, Ingo Molnar wrote:
> >
> >* Daniel Borkmann <daniel@iogearbox.net> wrote:
> >
> >>While testing some other BPF issue, I realized that BPF_EVENTS is
> >>actually not accessible through menuconfig because of a missing
> >>description that needs to be attached to the bool. After the patch
> >>the entry shows up in menuconfig and can be enabled/disabled from
> >>there.
> >
> > Yeah, so the principle is the following: the main configuration option for it 
> > is BPF_SYSCALL. The BPF_EVENTS is an internal detail, always enabled when 
> > possible, and we make it so that if the BPF syscall is enabled, we'll enable 
> > the perf integration if all the must-have components are in place:
> 
> Makes sense, yes. I probably got confused due to the help text on the hidden 
> Kconfig entry, but that can nevertheless serve as documentation purpose.

Feel free to send a patch that adds a sentence to that help text that explains 
that this is an internal helper Kconfig entry that does not need to be 
interactively configurable.

Thanks,

	Ingo