From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org, sre@kernel.org,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux@roeck-us.net, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [PATCH v3 1/2] ARM: at91/dt: shdwc binding: add new shutdown controller documentation
Date: Sat, 3 Oct 2015 19:02:20 +0200 [thread overview]
Message-ID: <20151003170220.GG2694@piout.net> (raw)
In-Reply-To: <1443630121-13912-2-git-send-email-nicolas.ferre@atmel.com>
On 30/09/2015 at 18:22:00 +0200, Nicolas Ferre wrote :
> +SHDWC Shutdown Controller (Alternative)
> +
> +1) shdwc node
> +
> +required properties:
> +- compatible: should be "atmel,sama5d2-shdwc".
> +- reg: should contain registers location and length
> +- clocks: phandle to input clock.
> +- #address-cells: should be one. The cell is the wake-up input index.
> +- #size-cells: should be zero.
> +
> +optional properties:
> +
> +- atmel,wakeup-debouncer: minimum wake-up inputs debouncer period in
Shouldn't that property be called atmel,wakeup-debouncer-ms ?
> +
> +2) input nodes
> +
> +Wake-up input nodes are usually described in the "board" part of the Device
> +Tree. Note also that input 0 is linked to the wake-up pin and is frequently
> +used.
> +
> +Required properties:
> +- reg: should contain the wake-up input index [0 - 15].
> +
> +Optional properties:
> +- atmel,wakeup-type: string, operation mode of the input described by the child
> + node. Supported values are: "high" or "low".
> +
Maybe we could avoid parsing string and use an integer with a few defines
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-03 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 16:21 [PATCH v3 0/2] power: reset: support for Atmel alternative Shutdown Controller Nicolas Ferre
2015-09-30 16:22 ` [PATCH v3 1/2] ARM: at91/dt: shdwc binding: add new shutdown controller documentation Nicolas Ferre
2015-10-03 17:02 ` Alexandre Belloni [this message]
2016-03-07 14:31 ` Nicolas Ferre
2015-09-30 16:22 ` [PATCH v3 2/2] power: reset: at91-shdwc: add new shutdown controller driver Nicolas Ferre
2015-09-30 16:45 ` kbuild test robot
2015-10-01 15:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151003170220.GG2694@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox