From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751800AbbJDTOX (ORCPT ); Sun, 4 Oct 2015 15:14:23 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51146 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbbJDTOW (ORCPT ); Sun, 4 Oct 2015 15:14:22 -0400 Date: Sun, 4 Oct 2015 20:14:16 +0100 From: Greg KH To: Eric Biggers Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: Update help for firmware loading options Message-ID: <20151004191416.GB9649@kroah.com> References: <1439157676-23220-1-git-send-email-ebiggers3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439157676-23220-1-git-send-email-ebiggers3@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 09, 2015 at 05:01:16PM -0500, Eric Biggers wrote: > Update the help text to account for the fact that the kernel can now load > firmware directly from the filesystem. Also clarify how the FW_LOADER > option works. > > Signed-off-by: Eric Biggers > --- > drivers/base/Kconfig | 33 +++++++++++++++++++++------------ > 1 file changed, 21 insertions(+), 12 deletions(-) > > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index 98504ec..2150f6c 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @@ -78,12 +78,21 @@ config PREVENT_FIRMWARE_BUILD > If unsure, say Y here. > > config FW_LOADER > - tristate "Userspace firmware loading support" if EXPERT > + tristate "Firmware loading support" if EXPERT Are you sure? I think this should stay as "Userspace..." as that is what it does, right? Turning it off should only drop the userspace callouts, it shouldn't stop the kernel from loading firmware from the filesystem all on its own with no help. thanks, greg k-h