From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816AbbJDTZJ (ORCPT ); Sun, 4 Oct 2015 15:25:09 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:35293 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518AbbJDTZH (ORCPT ); Sun, 4 Oct 2015 15:25:07 -0400 Date: Sun, 4 Oct 2015 14:24:55 -0500 From: Eric Biggers To: Greg KH Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: Update help for firmware loading options Message-ID: <20151004192455.GA8829@zyxyz> References: <1439157676-23220-1-git-send-email-ebiggers3@gmail.com> <20151004191416.GB9649@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151004191416.GB9649@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 04, 2015 at 08:14:16PM +0100, Greg KH wrote: > > Are you sure? I think this should stay as "Userspace..." as that is > what it does, right? > > Turning it off should only drop the userspace callouts, it shouldn't > stop the kernel from loading firmware from the filesystem all on its own > with no help. As far as I can tell that's not true. With FW_LOADER=n, firmware_class.c is compiled out and request_firmware() always returns -EINVAL. My patch tries to make it more clear that FW_LOADER is the "top-level" option which covers all three firmware loading mechanisms: built-in, directly from the filesystem, and the user-mode helper.