From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751977AbbJEBvY (ORCPT ); Sun, 4 Oct 2015 21:51:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:53067 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbbJEBvW (ORCPT ); Sun, 4 Oct 2015 21:51:22 -0400 Date: Sun, 4 Oct 2015 18:50:55 -0700 From: Davidlohr Bueso To: Geliang Tang Cc: Andrew Morton , "Kirill A. Shutemov" , Hugh Dickins , "Peter Zijlstra (Intel)" , Andrea Arcangeli , Joonsoo Kim , Arnd Bergmann , Paul Gortmaker , Leon Romanovsky , Oleg Nesterov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON() Message-ID: <20151005015055.GA8831@linux-uzut.site> Mail-Followup-To: Geliang Tang , Andrew Morton , "Kirill A. Shutemov" , Hugh Dickins , "Peter Zijlstra (Intel)" , Andrea Arcangeli , Joonsoo Kim , Arnd Bergmann , Paul Gortmaker , Leon Romanovsky , Oleg Nesterov , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <45bf632d263280847a2a894017c62b7f2a71eda1.1443937856.git.geliangtang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <45bf632d263280847a2a894017c62b7f2a71eda1.1443937856.git.geliangtang@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 04 Oct 2015, Geliang Tang wrote: >BUG_ON() already contain an unlikely compiler flag. Drop it. > >Signed-off-by: Geliang Tang Acked-by: Davidlohr Bueso ... but I believe you do have some left: drivers/scsi/scsi_lib.c: BUG_ON(unlikely(count > ivecs)); drivers/scsi/scsi_lib.c: BUG_ON(unlikely(count > queue_max_integrity_segments(rq->q))); kernel/sched/core.c: BUG_ON(unlikely(task_stack_end_corrupted(prev)));