From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752091AbbJECbD (ORCPT <rfc822;w@1wt.eu>);
	Sun, 4 Oct 2015 22:31:03 -0400
Received: from m50-135.163.com ([123.125.50.135]:58008 "EHLO m50-135.163.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751495AbbJECbB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 4 Oct 2015 22:31:01 -0400
Date: Mon, 5 Oct 2015 10:30:00 +0800
From: Geliang Tang <geliangtang@163.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Hugh Dickins <hughd@google.com>,
        "Peter Zij lstra (Intel)" <peterz@infradead.org>,
        Andrea Arcangeli <aarcange@redhat.com>, Joonsoo Kim <js1304@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Leon Romanovsky <leon@leon.nu>, Oleg Nesterov <oleg@redhat.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()
Message-ID: <20151005023000.GA1607@bogon>
References: <a89c7bef0699c3d3f5e592c58ff3f0a4db482b69.1443937856.git.geliangtang@163.com>
 <cf38aa69e23adb31ebb4c9d80384dabe9b91b75e.1443937856.git.geliangtang@163.com>
 <45bf632d263280847a2a894017c62b7f2a71eda1.1443937856.git.geliangtang@163.com>
 <20151005015055.GA8831@linux-uzut.site>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151005015055.GA8831@linux-uzut.site>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-CM-TRANSID: D9GowAC3nUqo4BFWSIOgCw--.6446S3
X-Coremail-Antispam: 1Uf129KBjvdXoWrurWrZF1UXr4UAFW8urWDtwb_yoWxCrc_AF
	Wv9r4Ivan8Kw4xAw1aqrW7Aryqgay8XF1kAas8Kry3AFsaqFZ8tr4DAw1xur4kKrsF9r15
	Jwn2vryjyw4UtjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT
	9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8fMaUUUUUU==
X-Originating-IP: [116.77.128.24]
X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/xtbBygqKmVO+fDMnHAAAsK
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 04, 2015 at 06:50:55PM -0700, Davidlohr Bueso wrote:
> On Sun, 04 Oct 2015, Geliang Tang wrote:
> 
> >BUG_ON() already contain an unlikely compiler flag. Drop it.
> >
> >Signed-off-by: Geliang Tang <geliangtang@163.com>
> 
> Acked-by: Davidlohr Bueso <dave@stgolabs.net>
> 
> ... but I believe you do have some left:
> 
> drivers/scsi/scsi_lib.c:                BUG_ON(unlikely(count > ivecs));
> drivers/scsi/scsi_lib.c:                BUG_ON(unlikely(count > queue_max_integrity_segments(rq->q)));
> kernel/sched/core.c:    BUG_ON(unlikely(task_stack_end_corrupted(prev)));

Thanks for your review, the left have been sended out already in two other patches.