Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()

Geliang Tang
2015-10-05T02:31:03Z

On Sun, Oct 04, 2015 at 06:50:55PM -0700, Davidlohr Bueso wrote:
> On Sun, 04 Oct 2015, Geliang Tang wrote:
>
> >BUG_ON() already contain an unlikely compiler flag. Drop it.
> >
> >Signed-off-by: Geliang Tang <geliangtang@163.com>
>
> Acked-by: Davidlohr Bueso <dave@stgolabs.net>
>
> ... but I believe you do have some left:
>
> drivers/scsi/scsi_lib.c: BUG_ON(unlikely(count > ivecs));
> drivers/scsi/scsi_lib.c: BUG_ON(unlikely(count > queue_max_integrity_segments(rq->q)));
> kernel/sched/core.c: BUG_ON(unlikely(task_stack_end_corrupted(prev)));

Thanks for your review, the left have been sended out already in two other patches.