public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-usb@vger.kernel.org, balbi@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] bdc_pci: use PCI_VDEVICE() instead of PCI_DEVICE()
Date: Mon, 5 Oct 2015 04:16:19 +0100	[thread overview]
Message-ID: <20151005031619.GC27303@kroah.com> (raw)
In-Reply-To: <1880175.9DxO9yLYxx@wasted.cogentembedded.com>

On Mon, Oct 05, 2015 at 12:08:26AM +0300, Sergei Shtylyov wrote:
> Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE().

Why?  I hate PCI_VDEVICE(), it's impossible to grep for things and does
not help with readability and is pointless.  My one wish was that when I
was the PCI maintainer I would have just deleted the thing from the
kernel entirely instead of leaving it there hoping no one would use it.

I don't like these types of pointless patches, sorry.

thanks,

greg k-h

  reply	other threads:[~2015-10-05  3:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-04 20:38 [PATCH 0/8] USB: use PCI_VDEVICE() instead of PCI_DEVICE() Sergei Shtylyov
2015-10-04 20:50 ` [PATCH 1/8] ehci-pci: " Sergei Shtylyov
2015-10-04 20:52 ` [PATCH 2/8] ohci-pci:-use-PCI_VDEVICE() " Sergei Shtylyov
2015-10-04 20:55 ` [PATCH 3/8] chipidea: ci_hdrc_pci: use PCI_VDEVICE() " Sergei Shtylyov
2015-10-04 21:00 ` [PATCH 4/8] dwc2: pci: " Sergei Shtylyov
2015-10-04 21:02 ` [PATCH 5/8] dwc3-pci: " Sergei Shtylyov
2015-10-04 21:04 ` [PATCH 6/8] amd5536udc: " Sergei Shtylyov
2015-10-04 21:07 ` [PATCH 7/8] pch_udc: " Sergei Shtylyov
2015-10-04 21:08 ` [PATCH 8/8] bdc_pci: " Sergei Shtylyov
2015-10-05  3:16   ` Greg KH [this message]
2015-10-05 13:13     ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151005031619.GC27303@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox