From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752193AbbJEDQY (ORCPT ); Sun, 4 Oct 2015 23:16:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36495 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbbJEDQW (ORCPT ); Sun, 4 Oct 2015 23:16:22 -0400 Date: Mon, 5 Oct 2015 04:16:19 +0100 From: Greg KH To: Sergei Shtylyov Cc: linux-usb@vger.kernel.org, balbi@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] bdc_pci: use PCI_VDEVICE() instead of PCI_DEVICE() Message-ID: <20151005031619.GC27303@kroah.com> References: <60171155.g7UZoV0Hgv@wasted.cogentembedded.com> <1880175.9DxO9yLYxx@wasted.cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1880175.9DxO9yLYxx@wasted.cogentembedded.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2015 at 12:08:26AM +0300, Sergei Shtylyov wrote: > Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). Why? I hate PCI_VDEVICE(), it's impossible to grep for things and does not help with readability and is pointless. My one wish was that when I was the PCI maintainer I would have just deleted the thing from the kernel entirely instead of leaving it there hoping no one would use it. I don't like these types of pointless patches, sorry. thanks, greg k-h