From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751963AbbJEHEw (ORCPT ); Mon, 5 Oct 2015 03:04:52 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:37729 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbbJEHEu (ORCPT ); Mon, 5 Oct 2015 03:04:50 -0400 Date: Mon, 5 Oct 2015 09:04:45 +0200 From: Ingo Molnar To: Yuyang Du Cc: peterz@infradead.org, linux-kernel@vger.kernel.org, pjt@google.com, bsegall@google.com, morten.rasmussen@arm.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com Subject: Re: [PATCH 1/4] sched/fair: Generalize the load/util averages resolution definition Message-ID: <20151005070445.GA10526@gmail.com> References: <1443981419-16665-1-git-send-email-yuyang.du@intel.com> <1443981419-16665-2-git-send-email-yuyang.du@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443981419-16665-2-git-send-email-yuyang.du@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yuyang Du wrote: > +# define SCHED_RESOLUTION_SHIFT 10 > #if 0 /* BITS_PER_LONG > 32 -- currently broken: it increases power usage under light load */ Might be worth fixing? Also, I noticed this: > -# define SCHED_LOAD_RESOLUTION 10 > +# define SCHED_LOAD_SHIFT (SCHED_RESOLUTION_SHIFT + SCHED_RESOLUTION_SHIFT) So in the #if 0 (inactive) section we change it from 10 to 20 ... > -# define SCHED_LOAD_RESOLUTION 0 > +# define SCHED_LOAD_SHIFT (SCHED_RESOLUTION_SHIFT) > # define scale_load(w) (w) > # define scale_load_down(w) (w) > #endif > > -#define SCHED_LOAD_SHIFT (10 + SCHED_LOAD_RESOLUTION) ... then we change the actually active definition from 20 to 10? Was that intended? Please double check the 'make allyesconfig' disassembly of kernel/sched/built-in.o before/after this patch to make sure it does not change any code. ( No full allyesconfig build needed: 'make -j16 kernel/sched' should cut down on the build time. ) Thanks, Ingo