From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752447AbbJEI2G (ORCPT ); Mon, 5 Oct 2015 04:28:06 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34344 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbbJEI2F (ORCPT ); Mon, 5 Oct 2015 04:28:05 -0400 Date: Mon, 5 Oct 2015 09:28:00 +0100 From: Lee Jones To: Andy Shevchenko Cc: Lee Jones , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP Message-ID: <20151005082800.GB3243@x1> References: <1443704817-70402-1-git-send-email-andriy.shevchenko@linux.intel.com> <20151001144539.GA3214@x1> <1443788513.8361.333.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1443788513.8361.333.camel@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 02 Oct 2015, Andy Shevchenko wrote: > On Thu, 2015-10-01 at 15:45 +0100, Lee Jones wrote: > > On Thu, 01 Oct 2015, Andy Shevchenko wrote: > > > > > Jim Davis reported the compilation error with a random > > > configuration which > > > apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that > > > conditions we have > > > missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here. > > > > > > Reported-by: Jim Davis > > > Signed-off-by: Andy Shevchenko > > > --- > > > drivers/mfd/intel-lpss.h | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Why are you using this email address? > > In fact it *had* the proper address [1] and after you confused me [2]. > > [1] http://www.spinics.net/lists/kernel/msg2073973.html This was the original patch submission, which was correct. https://lkml.org/lkml/2015/10/1/484 However this email you sent to the wrong address. > [2] http://www.spinics.net/lists/linux-fsdevel/msg90269.html Then you followed up with a patch, also to the wrong address. BTW: This patch has already been applied to my -fixes branch and will be sent to Mainline in a week or so. > > Please use ./get_maintainer.pl properly. > > > > > diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h > > > index f28cb28a..2c7f8d7 100644 > > > --- a/drivers/mfd/intel-lpss.h > > > +++ b/drivers/mfd/intel-lpss.h > > > @@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev); > > > .thaw = intel_lpss_resume, \ > > > .poweroff = intel_lpss_suspend, \ > > > .restore = intel_lpss_resume, > > > +#else > > > +#define INTEL_LPSS_SLEEP_PM_OPS > > > #endif > > > > > > #define INTEL_LPSS_RUNTIME_PM_OPS \ > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog