From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbbJEIls (ORCPT ); Mon, 5 Oct 2015 04:41:48 -0400 Received: from down.free-electrons.com ([37.187.137.238]:55052 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752450AbbJEIlp (ORCPT ); Mon, 5 Oct 2015 04:41:45 -0400 Date: Mon, 5 Oct 2015 10:41:33 +0200 From: Maxime Ripard To: Code Kipper Cc: Liam Girdwood , linux-arm-kernel , Mark Brown , linux-sunxi , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, "Andrea Venturi (pers)" Subject: Re: [PATCH v2 1/4] dt-bindings: add sunxi SPDIF transceiver bindings Message-ID: <20151005084133.GE2696@lukather> References: <1443635458-8873-1-git-send-email-codekipper@gmail.com> <1443635458-8873-2-git-send-email-codekipper@gmail.com> <20151001201215.GN7104@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wULyF7TL5taEdwHz" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wULyF7TL5taEdwHz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 02, 2015 at 07:24:20AM +0200, Code Kipper wrote: > >> + > >> + - compatible : should be one of the following: > >> + - "allwinner,sun4i-a10-spdif": for the Allwinner A10 SoC > >> + - "allwinner,sun7i-a20-spdif": for the Allwinner A20 SoC > >> + - "allwinner,sun6i-a31-spdif": for the Allwinner A31 SoC > > > > Are all these compatibles really work? Is there any significant > > difference between the controller on all these SoCs? > > Let us assume that there isn't any difference. Remember SPDIF details > for all of these devices is sketchy. In the A10 User Manual, it's not > even mentioned although devices such as the Mele A2000 which I use > come with the physical connector. It's only when the A20 Manual was > released that we see the pin details and related components. We didn't > see a SPDIF block spec until the H3 User Manual was released. >=20 > Looking at the SDK code I've only seen fifo level settings to be > different for the sun6i family. It was this release that also showed > Rx rotines. The fact of the matter is we won't know until these SoCs > have been tested and with that in mind I'm happy to remove all > capabilities for now until then. The point was more that you document compatibles that you are not actually supporting. You've only tested it on one SoC (and it actually works only on one SoC, or at least with one compatible), so only document that. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --wULyF7TL5taEdwHz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWEje9AAoJEBx+YmzsjxAgRloP/jt2M/o7WPKF25dMuvIUFkZy j8vxXh5iJpAJ/5P8jilXj9jOrH200p/reinXbE/8slYfI35p3wUCLmFGBaT1ZILP Q+OQMmL3jMi/bkGeAYN0KN5Bg24jJ4Z9cuB4i7YDqG8Wyh7YUlI6GTNwLvMnw4t4 EKaqE2EJzrxW2sbqg5xQEU828GpGAIHBOwctbvzcCD23+DAtsaZhcKtjKK3/KUNk 7hP9jl+SSbP8VeBpu1DIhhW/jSelc7ZNh9yY6fweys0CBaUKikMUoCinfuGw6vuT qit0m+ezxf4gNq7Xx4mIfHSuJcZwLJ8icYE19s4Rkd40ym2WVBZNm1pb5mKzVc4f AL7uhX1deENH/IUFg7CzII1kHtc1n5kt5joa17vWTswKx52nSvovnH0+4vYT77hh zf3ZFPZ+gpQdhIIuV1otU7Hgs6fZ78fUJ0EhUHm9KJP+rYgFP2kSBZaBv55IkfqV +1ON0NglT5wg6PtuY6iA87uCVms3zUb0158vBHoy620AuCagodSY0GeJ6KEKD243 By0RG6ciBvU1IoTBhOl+NE+7PThhkM1lv9lbEEXa3YSXt+1oBa9BZQSi/lZuh8Zu VpMF1bEJMEuSnRusLHarWPrUfL20egjGwGsZbHkeuHu6ibvNY9QYbNZlKTtznNFG CK3NQgXA3XkKahK7saq1 =BVKl -----END PGP SIGNATURE----- --wULyF7TL5taEdwHz--