From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983AbbJEKNq (ORCPT ); Mon, 5 Oct 2015 06:13:46 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36863 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752565AbbJEKNo (ORCPT ); Mon, 5 Oct 2015 06:13:44 -0400 Date: Mon, 5 Oct 2015 15:43:32 +0530 From: Sudip Mukherjee To: Dan Carpenter Cc: devel@driverdev.osuosl.org, Lidza Louina , Daeseok Youn , driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] staging: dgap: remove unused configuration Message-ID: <20151005101332.GA338@sudip-pc> References: <1443973760-21093-1-git-send-email-sudipm.mukherjee@gmail.com> <20151005094643.GM7340@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151005094643.GM7340@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2015 at 12:46:43PM +0300, Dan Carpenter wrote: > On Sun, Oct 04, 2015 at 09:19:20PM +0530, Sudip Mukherjee wrote: > > The IO configuration was not used to configure the board. It was only > > read from the configuration file. Stop reading it and also remove the > > other related variables defined for it. > > > > Signed-off-by: Sudip Mukherjee > > But say someone has an old config file with IO in it, doesn't this break > their system? No, it should not. dgap_parsefile() is executing a loop and reading tokens from the configuration file and depending on what token it has read it will do switch-case. And it will not find case IO: anymore and will be just ignored (there is no default:). And this is actually just a first step towards removing the configuration file as Greg was telling that loading a firmware file and consideing it as a configuartion file is not the right thing to do. So I am removing all the unused configurations one at a time and after they are removed then depending on the configurations left I will ask for your suggestion how to remove the use of configuration file. regards sudip