From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751944AbbJEKqE (ORCPT ); Mon, 5 Oct 2015 06:46:04 -0400 Received: from muru.com ([72.249.23.125]:55892 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbbJEKqB (ORCPT ); Mon, 5 Oct 2015 06:46:01 -0400 Date: Mon, 5 Oct 2015 03:45:57 -0700 From: Tony Lindgren To: Felipe Balbi Cc: Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List , daniel.lezcano@linaro.org, tglx@linutronix.de Subject: Re: [RFC/PATCH 11/11] arm: boot: dts: omap: add missing default status for 32k counter Message-ID: <20151005104556.GT23801@atomide.com> References: <1443559446-26969-1-git-send-email-balbi@ti.com> <1443559446-26969-12-git-send-email-balbi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443559446-26969-12-git-send-email-balbi@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Felipe Balbi [150929 13:48]: > All devices should have a default status. Ignoring > the arguments if it should be 'okay' or 'disabled' > by default, let's set them all the 'disabled' and > have boards enable 32k counter. We should not use "disabled" really at all. That means no struct device is ever created while that hardawre is there for the internal devices for sure. Also, we should use the 32k counter as the default one as that's always on for deeper idle states. For cases where the 32k ocillator is not available, it's better to just set the source clock rate to 0 in the board specific dts file and have the driver bail out early if source clock rate is 0. Regards, Tony