From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752309AbbJEOhe (ORCPT ); Mon, 5 Oct 2015 10:37:34 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:2366 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbbJEOh3 (ORCPT ); Mon, 5 Oct 2015 10:37:29 -0400 Date: Mon, 5 Oct 2015 10:32:46 -0400 From: Chris Mason To: Neil Brown CC: , Josef Bacik , Jan Kara , Ryusuke Konishi , , , , , Subject: Re: [PATCH 1/3] BTRFS: support NFSv2 export Message-ID: <20151005143246.GW25218@ret.masoncoding.com> Mail-Followup-To: Chris Mason , Neil Brown , dsterba@suse.cz, Josef Bacik , Jan Kara , Ryusuke Konishi , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20150508001142.31129.7604.stgit@notabene.brown> <20150508001623.31129.91695.stgit@notabene.brown> <20150511081309.GI23255@suse.cz> <87r3lowpax.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87r3lowpax.fsf@notabene.neil.brown.name> User-Agent: Mutt/1.5.23.1 (2014-03-12) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-10-05_06:2015-10-05,2015-10-05,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2015 at 11:59:02AM +1000, Neil Brown wrote: > David Sterba writes: > > > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote: > >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as > >> that returned by encode_fh - it may be larger. > >> > >> With NFSv2, the filehandle is fixed length, so it may appear longer > >> than expected and be zero-padded. > >> > >> So we must test that fh_len is at least some value, not exactly equal > >> to it. > >> > >> Signed-off-by: NeilBrown > > > > Acked-by: David Sterba > > Thanks. However I just checked mainline and this still hasn't been > applied. > Should I resend it to someone? Who? Sorry Neil, I thought you were pushing these after it was ack'd. I'll put it in my pull this week. -chris