From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322AbbJEWDa (ORCPT ); Mon, 5 Oct 2015 18:03:30 -0400 Received: from down.free-electrons.com ([37.187.137.238]:42255 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751238AbbJEWD2 (ORCPT ); Mon, 5 Oct 2015 18:03:28 -0400 Date: Tue, 6 Oct 2015 00:03:26 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] irqchip: sunxi-nmi: Use driver name instead of DT node name for identification Message-ID: <20151005220326.GP2696@lukather> References: <1444063334-19832-1-git-send-email-wens@csie.org> <1444063334-19832-2-git-send-email-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UFMLoheMaWcIEZAi" Content-Disposition: inline In-Reply-To: <1444063334-19832-2-git-send-email-wens@csie.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --UFMLoheMaWcIEZAi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 06, 2015 at 12:42:13AM +0800, Chen-Yu Tsai wrote: > The device tree node name is typically "interrupt-controller", which is > rather useless when used in printk messages and irq chip names for > identification purposes. Use the driver name "sunxi-nmi" instead. >=20 > While at it move the identifier from pr_err() calls to the pr_fmt macro. >=20 > Also remove the "__func__" identifier from the error message in the > interrupt type setting callback, sunxi_sc_nmi_set_type(). The driver > name in the pr_fmt macro should be enough. >=20 > Signed-off-by: Chen-Yu Tsai Acked-by: Maxime Ripard Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --UFMLoheMaWcIEZAi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWEvOuAAoJEBx+YmzsjxAgAogP/jfW6TOUsNO5BYjmIcuQwAXT CL++GuF2UJ5E3dCphvJZP/K9y13ZANWePPS9+BNYXeYiAFjvfIRJzDlRZ8Ll0cYK Ox4qd4AHuvD9PfMaJKNv3kg7R9crJURdBQNnXQuzvtLV0OTn9pQZoEAEGv6zAKpS PSdahy5pKRbGeXFCx1PQBQ9vGAIW+qtm6xkrnm563cn7i6gcO32wcBA4RLzMaOti MiqbFli68LwcITiSPE2evqNRfXkVkWaSXNbOWkUJ/guleRbj8a4HONZ5Wya5KChi RLV/x0uHSye7fQidtpa5TiZrSm2wRERlJOcITse9njU2nt+uh0SVJICScy83AX4B q47DErOFsuraFbMRAvRZ2GIgXKy5IJncX3poDICwNIUoSsegYUbrXOGTt5WTS/sC tABx0xQfXUSb5BKiKQREgd9JD9P9MyJYAXZFBKUCRqpQODi2eWs+OmbtSdBySZsc crjjE+9XBzMv2CJ8xXXBKydbkaha5/2L+jpXcua7stSNRlJvovOFY6Ej9ZE6R5no bIZ01jFrnKSkgH9XTLXQFd0WWRwoepd3L7u5Ut4znWkGFwT4CG9YceX8WXbpZbpd ASkwvfozOMwIcHRo7D4lhP+VpU2df8OPTPareA6z81Lh8OTkPt7d2E+wCXe2Y1+3 tXBQ9XdLhGZpaE7EccWV =+PTn -----END PGP SIGNATURE----- --UFMLoheMaWcIEZAi--