From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbbJFIXM (ORCPT ); Tue, 6 Oct 2015 04:23:12 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:38209 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbbJFIXK (ORCPT ); Tue, 6 Oct 2015 04:23:10 -0400 Date: Tue, 6 Oct 2015 10:23:06 +0200 From: Ingo Molnar To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Brian Gerst , Denys Vlasenko , Linus Torvalds , Borislav Petkov Subject: Re: [PATCH v2 09/36] x86/asm: Re-add manual CFI infrastructure Message-ID: <20151006082305.GB18287@gmail.com> References: <4c70bb98a8b773c8ccfaabf6745e569ff43e7f65.1444091584.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c70bb98a8b773c8ccfaabf6745e569ff43e7f65.1444091584.git.luto@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andy Lutomirski wrote: > Commit 131484c8da97 ("x86/debug: Remove perpetually broken, > unmaintainable dwarf annotations") removed all the manual DWARF > annotations outside the vDSO. It also removed the macros we used > for the manual annotations. > > Re-add the macros so that we can clean up the vDSO annotations. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/Makefile | 10 ++- > arch/x86/include/asm/dwarf2.h | 170 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 178 insertions(+), 2 deletions(-) > create mode 100644 arch/x86/include/asm/dwarf2.h Please don't add all this gunk back in! AFAICS the later patches use just a very small subset - add only the minimal subset absolutely needed. Thanks, Ingo