From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752701AbbJFJCC (ORCPT ); Tue, 6 Oct 2015 05:02:02 -0400 Received: from foss.arm.com ([217.140.101.70]:51342 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbbJFJB6 (ORCPT ); Tue, 6 Oct 2015 05:01:58 -0400 Date: Tue, 6 Oct 2015 10:01:52 +0100 From: Will Deacon To: Peter Zijlstra Cc: Davidlohr Bueso , Ingo Molnar , Thomas Gleixner , Andrew Morton , Linus Torvalds , "Paul E.McKenney" , "linux-kernel@vger.kernel.org" , Davidlohr Bueso Subject: Re: [PATCH 1/5] asm-generic: Add _{relaxed|acquire|release}() variants for inc/dec atomics Message-ID: <20151006090152.GA10492@arm.com> References: <1443643395-17016-1-git-send-email-dave@stgolabs.net> <1443643395-17016-2-git-send-email-dave@stgolabs.net> <20151001063910.GN2881@worktop.programming.kicks-ass.net> <20151005173243.GF3211@arm.com> <20151005194824.GF3816@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151005194824.GF3816@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2015 at 09:48:24PM +0200, Peter Zijlstra wrote: > On Mon, Oct 05, 2015 at 06:32:43PM +0100, Will Deacon wrote: > > On Thu, Oct 01, 2015 at 07:39:10AM +0100, Peter Zijlstra wrote: > > > On Wed, Sep 30, 2015 at 01:03:11PM -0700, Davidlohr Bueso wrote: > > > > Similar to what we have for regular add/sub calls. For now, no actual arch > > > > implements them, so everyone falls back to the default atomics... iow, > > > > nothing changes. These will be used in future primitives. > > > > > > > > > > Maybe also do an aargh64 patch for this? > > > > I can follow up with that, since I'm about 60% through adding the > > relaxed/acquire/release versions of all the other primitives. It's a fair > > amount of work thanks to the new atomic instructions making me do everything > > twice... (that and I've been on holiday this past week!) > > Right, what I meant was arm (I thought argh64 was the one with _relaxed > bits in, but my memories tricked me, it was ARM). > > If you add new _relaxed ops, we'd better convert all archs that support > _relaxed, which would be ARM (for now). Right, yeah, arch/arm/ will need updating along with this series. Should be straightforward to implement them in terms of atomic_{add,sub}_*. Will