Re: [PATCH net-next v2 2/2] net: Microchip encx24j600 driver

David Miller
2015-10-05T10:45:05Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 1724 bytes --]

From: David Miller <davem@davemloft.net>
Date: Mon, 05 Oct 2015 03:54:55 -0700 (PDT)

> From: jon@ringle.org
> Date: Thu, 1 Oct 2015 07:43:21 -0400
>
>> From: Jon Ringle <jringle@gridpoint.com>
>>
>> This ethernet driver supports the Micorchip enc424j600/626j600 Ethernet
>> controller over a SPI bus interface. This driver makes use of the regmap API to
>> optimize access to registers by caching registers where possible.
>>
>> Datasheet:
>> http://ww1.microchip.com/downloads/en/DeviceDoc/39935b.pdf
>>
>> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
>
> Applied.

Actually, I had to revert both patches. Please look at the compiler
warnings your code generates:

drivers/mfd/wm5110-tables.c: In function ¡wm5110_patch¢:
drivers/mfd/wm5110-tables.c:281:11: warning: passing argument 2 of ¡regmap_register_patch¢ from incompatible pointer type [enabled by default]
In file included from include/linux/mfd/arizona/core.h:17:0,
from drivers/mfd/wm5110-tables.c:15:
include/linux/regmap.h:727:5: note: expected ¡const struct reg_sequence *¢ but argument is of type ¡const struct reg_default *¢
drivers/mfd/wm8998-tables.c: In function ¡wm8998_patch¢:
drivers/mfd/wm8998-tables.c:50:10: warning: passing argument 2 of ¡regmap_register_patch¢ from incompatible pointer type [enabled by default]
In file included from include/linux/mfd/arizona/core.h:17:0,
from drivers/mfd/wm8998-tables.c:15:
include/linux/regmap.h:727:5: note: expected ¡const struct reg_sequence *¢ but argument is of type ¡const struct reg_default *¢
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥