From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Bryan Wu" <cooloney@gmail.com>,
"Richard Purdie" <rpurdie@rpsys.net>,
"Jacek Anaszewski" <j.anaszewski@samsung.com>,
linux-leds@vger.kernel.org, "Heiko Stuebner" <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
"Jingoo Han" <jingoohan1@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
linux-fbdev@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
"Doug Anderson" <dianders@google.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Maxime Ripard" <maxime.ripard@free-electrons.com>
Subject: Re: [PATCH v2 01/10] pwm: introduce default period and polarity concepts
Date: Tue, 6 Oct 2015 12:09:35 +0200 [thread overview]
Message-ID: <20151006100935.GK2694@piout.net> (raw)
In-Reply-To: <1437406327-6207-2-git-send-email-boris.brezillon@free-electrons.com>
On 20/07/2015 at 17:31:58 +0200, Boris Brezillon wrote :
> When requested by a user, the PWM is assigned a default period and polarity
> extracted from the DT, the platform data or statically set by the driver.
> Those default values are currently stored in the period and polarity
> fields of the pwm_device struct, but they will be stored somewhere else
> once we have introduced the architecture allowing for hardware state
> retrieval.
>
> The pwm_set_default_polarity and pwm_set_default_period should only be
> used by PWM drivers or the PWM core infrastructure to specify the
> default period and polarity values.
>
> PWM users might call the pwm_get_default_period to query the default
> period value. There is currently no helper to query the default
> polarity, but it might be added later on if there is a need for it.
>
> This patch also modifies all the places where the default helpers should
> be used in place of the standard ones.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-06 10:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 15:31 [PATCH v2 00/10] pwm: add support for atomic update Boris Brezillon
2015-07-20 15:31 ` [PATCH v2 01/10] pwm: introduce default period and polarity concepts Boris Brezillon
2015-10-06 10:09 ` Alexandre Belloni [this message]
2015-07-20 15:31 ` [PATCH v2 02/10] pwm: define a new pwm_state struct Boris Brezillon
2015-07-20 15:32 ` [PATCH v2 03/10] pwm: move the enabled/disabled info to " Boris Brezillon
2015-07-20 15:32 ` [PATCH v2 04/10] backlight: pwm_bl: remove useless call to pwm_set_period Boris Brezillon
2015-07-20 15:32 ` [PATCH v2 05/10] pwm: declare a default PWM state Boris Brezillon
2015-07-20 15:32 ` [PATCH v2 06/10] pwm: add the PWM initial state retrieval infra Boris Brezillon
2015-07-20 15:32 ` [PATCH v2 07/10] pwm: add the core infrastructure to allow atomic update Boris Brezillon
2015-07-20 15:32 ` [PATCH v2 08/10] pwm: add information about polarity, duty cycle and period to debugfs Boris Brezillon
2015-07-20 15:32 ` [PATCH v2 09/10] pwm: rockchip: add initial state retrieval Boris Brezillon
2015-07-20 15:32 ` [PATCH v2 10/10] pwm: rockchip: add support for atomic update Boris Brezillon
2015-07-20 17:19 ` [PATCH v2 00/10] pwm: " Mark Brown
2015-07-20 19:49 ` Boris Brezillon
2015-07-20 20:08 ` Mark Brown
2015-07-20 20:21 ` Boris Brezillon
2015-07-25 6:36 ` Boris Brezillon
2015-08-17 7:18 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006100935.GK2694@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=dianders@google.com \
--cc=heiko@sntech.de \
--cc=j.anaszewski@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maxime.ripard@free-electrons.com \
--cc=plagnioj@jcrosoft.com \
--cc=rpurdie@rpsys.net \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox