From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753022AbbJFO2T (ORCPT ); Tue, 6 Oct 2015 10:28:19 -0400 Received: from mail.kernel.org ([198.145.29.136]:33836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbbJFO2P (ORCPT ); Tue, 6 Oct 2015 10:28:15 -0400 Date: Tue, 6 Oct 2015 11:28:07 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Peter Zijlstra Subject: Re: [RFC 0/3] perf tools: Make perf_hpp__init respect output dimensions Message-ID: <20151006142807.GM20515@kernel.org> References: <1444134312-29136-1-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Oct 06, 2015 at 11:04:28PM +0900, Namhyung Kim escreveu: > On Tue, Oct 6, 2015 at 9:25 PM, Jiri Olsa wrote: > > hi, > > The perf_hpp__init currently does not respect sorting dimensions > > and the setup_sorting function could endup queueing same format > > twice. That screwed up the perf_hpp__list and got stuck in loop > > within perf_hpp__setup_output_field function. > > > > $ perf report -F +overhead > > > > 0x00000000004c1355 in perf_hpp__is_sort_entry (format=format@entry=0x880440 ) at util/sort.c:1506 > > 1506 { > > > > #0 0x00000000004c1355 in perf_hpp__is_sort_entry (format=format@entry=0x880440 ) at util/sort.c:1506 > > #1 0x00000000004c139d in perf_hpp__same_sort_entry (a=a@entry=0x880440 , b=b@entry=0x2bb2fe0) at util/sort.c:1380 > > #2 0x00000000004f8d3c in perf_hpp__setup_output_field () at ui/hist.c:554 > > #3 0x00000000004c1d1e in setup_sorting () at util/sort.c:1984 > > #4 0x000000000042efbf in cmd_report (argc=0, argv=0x7ffea5a0e790, prefix=) at builtin-report.c:874 > > #5 0x0000000000476f13 in run_builtin (p=p@entry=0x875628 , argc=argc@entry=3, argv=argv@entry=0x7ffea5a0e790) at perf.c:385 > > #6 0x000000000047710b in handle_internal_command (argc=3, argv=0x7ffea5a0e790) at perf.c:445 > > #7 0x0000000000477176 in run_argv (argcp=argcp@entry=0x7ffea5a0e5fc, argv=argv@entry=0x7ffea5a0e5f0) at perf.c:489 > > #8 0x00000000004773e7 in main (argc=3, argv=0x7ffea5a0e790) at perf.c:606 > > > > Using hpp_dimension__add_output function to register > > the output column. It will also mark the dimension > > as taken and omit above stuck. > > > > It might need some other changes.. not sure, Namhyung? ;-) > > Nope. It looks good to me as is. :) It should work once it sets up > the output field and sort list properly, so > > Acked-by: Namhyung Kim Thanks, added. - Arnaldo