From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753035AbbJFQSx (ORCPT ); Tue, 6 Oct 2015 12:18:53 -0400 Received: from down.free-electrons.com ([37.187.137.238]:55121 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753237AbbJFQR7 (ORCPT ); Tue, 6 Oct 2015 12:17:59 -0400 Date: Tue, 6 Oct 2015 18:17:56 +0200 From: Maxime Ripard To: Julian Calaby Cc: "Mailing List, Arm" , Chen-Yu Tsai , Hans de Goede , "linux-kernel@vger.kernel.org" , linux-sunxi Subject: Re: [linux-sunxi] [PATCH v2 5/5] ARM: sun5i: Add C.H.I.P DTS Message-ID: <20151006161756.GT2696@lukather> References: <1444054990-15946-1-git-send-email-maxime.ripard@free-electrons.com> <1444054990-15946-6-git-send-email-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0blaZc+aUkVqY8MO" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0blaZc+aUkVqY8MO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Oct 06, 2015 at 12:15:38PM +1100, Julian Calaby wrote: > Hi Maxime, >=20 > On Tue, Oct 6, 2015 at 1:23 AM, Maxime Ripard > wrote: > > The C.H.I.P. is a small SBC with an Allwinner R8, 8GB of NAND, 512MB of > > RAM, USB host and OTG, a wifi / bluetooth combo chip, an audio/video ja= ck > > and two connectors to plug additional boards on top of it. >=20 > Sorry for the late review, but a couple of minor things stuck out at me. No problem :) > > Signed-off-by: Maxime Ripard > > Reviewed-by: Hans de Goede > > --- > > arch/arm/boot/dts/Makefile | 3 +- > > arch/arm/boot/dts/sun5i-r8-chip.dts | 224 ++++++++++++++++++++++++++++= ++++++++ > > 2 files changed, 226 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm/boot/dts/sun5i-r8-chip.dts > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index c7adaa85ef3f..2cf7e593270a 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -600,7 +600,8 @@ dtb-$(CONFIG_MACH_SUN5I) +=3D \ > > sun5i-a13-olinuxino.dtb \ > > sun5i-a13-olinuxino-micro.dtb \ > > sun5i-a13-q8-tablet.dtb \ > > - sun5i-a13-utoo-p66.dtb > > + sun5i-a13-utoo-p66.dtb \ > > + sun5i-r8-chip.dtb > > dtb-$(CONFIG_MACH_SUN6I) +=3D \ > > sun6i-a31-app4-evb1.dtb \ > > sun6i-a31-colombus.dtb \ > > diff --git a/arch/arm/boot/dts/sun5i-r8-chip.dts b/arch/arm/boot/dts/su= n5i-r8-chip.dts > > new file mode 100644 > > index 000000000000..08ff70601c79 > > --- /dev/null > > +++ b/arch/arm/boot/dts/sun5i-r8-chip.dts > > @@ -0,1 +1,224 @@ > > +/* > > + * Copyright 2015 Free Electrons > > + * Copyright 2015 NextThing Co > > + * > > + * Maxime Ripard > > + * > > + * This file is dual-licensed: you can use it either under the terms > > + * of the GPL or the X11 license, at your option. Note that this dual > > + * licensing only applies to this file, and not this project as a > > + * whole. > > + * > > + * a) This file is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation; either version 2 of = the > > + * License, or (at your option) any later version. > > + * > > + * This file is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * Or, alternatively, > > + * > > + * b) Permission is hereby granted, free of charge, to any person > > + * obtaining a copy of this software and associated documentation > > + * files (the "Software"), to deal in the Software without > > + * restriction, including without limitation the rights to use, > > + * copy, modify, merge, publish, distribute, sublicense, and/or > > + * sell copies of the Software, and to permit persons to whom the > > + * Software is furnished to do so, subject to the following > > + * conditions: > > + * > > + * The above copyright notice and this permission notice shall be > > + * included in all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > > + * OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +/dts-v1/; > > +#include "sun5i-a13.dtsi" >=20 > Am I missing something or should this include "sun5i-r8.dtsi" instead? Indeed. > > +#include "sunxi-common-regulators.dtsi" > > + > > +#include > > +#include > > + > > +/ { > > + model =3D "NextThing C.H.I.P."; > > + compatible =3D "nextthing,chip", "allwinner,sun5i-r8"; > > + > > + aliases { > > + i2c0 =3D &i2c0; > > + i2c1 =3D &i2c1; > > + i2c2 =3D &i2c2; > > + serial0 =3D &uart1; > > + serial1 =3D &uart3; > > + }; > > + > > + chosen { > > + stdout-path =3D "serial0:115200n8"; >=20 > Should the composite output be enabled here too? AFAIK, the stdout-path only supports a single output device, and I don't think it really is an issue since framebuffer console will attach to the framebuffer automatically. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --0blaZc+aUkVqY8MO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWE/Q0AAoJEBx+YmzsjxAgCFgP/0jZuurFQlpMsXvTwzdzuAPe J0bfmKXWchxmtdDjySchmaz1LGRtsHtD29lwdh2sl1Whdq+i+75g2CxC1xUR+1Ye 6aenbmZwb2hLu1fmPSSTVUovumP30uzGIJ7gx66XP54bgs5ywjrBOMWoR5RQVOx9 eOVqCdlVkozu2aX6IgFj++FGlYRx/bddyzR3i2q2hL+X5+NZ85lpXQxt2pi4NnWN XuCIDAs4r0oyBi2JU0/k0hEjQnVgXAZkjmix+wF3Sib1QcZ2cnN+ZVAU40XNctVr OXtkHC8LiBTP76JKfIfsAfFnEhVdc6znMxcnBeo5fYBwKHgldGxsNXEYWNuveCaN ZypVH15dA3ytEcRGkYcKjOEPuUleG9ZOxDaWzLA/7HIdR41KMe9QPlcqL+hNqwGa e9j89hod3QlKuJO0rABWkoG6dwJCHdTiRUMkkZbRgcvG+FFGXEMdt6OZX5m8jiyU jN6FDatXIgn71zIqPp+rAtdZj1f4YCxEDL6mHpZ7vv8GcRvur79YWhi9bxZE/iu8 nT5ncmtup9AzErttYfiwv0btxnD5AV+RgWnBmx0GlM5/pMOsmPhfkpchhY2/wHly aNQJyQh/yVPpIvrlCcv3epn1nD4HF8w5+6yqNE4Lad03+C+RjdEHwTaZVT+XX7WL BIgPxBiRofgLbxWMjJya =AJJc -----END PGP SIGNATURE----- --0blaZc+aUkVqY8MO--