From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752293AbbJFRmc (ORCPT <rfc822;w@1wt.eu>);
	Tue, 6 Oct 2015 13:42:32 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:56426 "EHLO
	relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752147AbbJFRmb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Oct 2015 13:42:31 -0400
Date: Tue, 6 Oct 2015 10:42:26 -0700
From: Josh Triplett <josh@joshtriplett.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com,
        dipankar@in.ibm.com, akpm@linux-foundation.org,
        mathieu.desnoyers@efficios.com, tglx@linutronix.de,
        peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com,
        edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com,
        oleg@redhat.com, bobby.prani@gmail.com
Subject: Re: [PATCH tip/core/rcu 0/13] percpu-rwsem patches for 4.4
Message-ID: <20151006174226.GK9600@cloud>
References: <20151006164514.GA15516@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151006164514.GA15516@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 06, 2015 at 09:45:14AM -0700, Paul E. McKenney wrote:
> Hello!
> 
> This series contains performance improvements and locktorture testing
> for percpu-rwsem:
> 
> 1.	Add rtmutex torturing to locktorture, courtesy of Davidlohr Bueso.
> 
> 2.	Add exports to allow locktorture to be built as a module.
> 
> 3.	Add torture tests for percpu-rwsem.
> 
> 4.	Consolidate cond_resched_rcu_qs() into stutter_wait().
> 
> 5.	Create rcu_sync infrastructure, courtesy of Oleg Nesterov.
> 
> 6.	Simplify rcu_sync using new rcu_sync_ops structure, courtesy
> 	of Oleg Nesterov.
> 
> 7.	Add CONFIG_PROVE_RCU checks for rcu_sync, courtesy of Oleg Nesterov.
> 
> 8.	Introduce rcu_sync_dtor(), courtesy of Oleg Nesterov.
> 
> 9.	Make percpu_free_rwsem() after kzalloc() safe, courtesy of Oleg
> 	Nesterov.
> 
> 10.	Make percpu-rwsem make use of rcu_sync, courtesy of Oleg Nesterov.
> 
> 11.	Fix the comments outdated by rcu_sync, courtesy of Oleg Nesterov.
> 
> 12.	Clean up the lockdep annotations in percpu_down_read(), courtesy
> 	Peter Zijlstra and of Oleg Nesterov.
> 
> 13.	Cleanup the CONFIG_PROVE_RCU checks, courtesy of Oleg Nesterov.

For all 13:
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Regarding the rcu_sync infrastructure: odd that an atomic read
on the reader proves ligher weight than
rcu_read_lock()/rcu_read_unlock().