From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752920AbbJFS1t (ORCPT ); Tue, 6 Oct 2015 14:27:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49057 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752193AbbJFS1s (ORCPT ); Tue, 6 Oct 2015 14:27:48 -0400 Date: Tue, 6 Oct 2015 21:27:42 +0300 From: "Michael S. Tsirkin" To: Vlad Zolotarov Cc: linux-kernel@vger.kernel.org, hjk@hansjkoch.de, corbet@lwn.net, gregkh@linuxfoundation.org, bruce.richardson@intel.com, avi@cloudius-systems.com, gleb@cloudius-systems.com, stephen@networkplumber.org, alexander.duyck@gmail.com Subject: Re: [PATCH v5 0/4] uio: add MSI/MSI-X support to uio_pci_generic driver Message-ID: <20151006212605-mutt-send-email-mst@redhat.com> References: <1444151859-10217-1-git-send-email-vladz@cloudius-systems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444151859-10217-1-git-send-email-vladz@cloudius-systems.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 06, 2015 at 08:17:35PM +0300, Vlad Zolotarov wrote: > This series add support for MSI and MSI-X interrupts to uio_pci_generic driver. > > Currently uio_pci_generic demands INT#x interrupts source be available. However > there are devices that simply don't have INT#x capability, for instance SR-IOV > VF devices that simply don't have INT#x capability. For such devices > uio_pci_generic will simply fail (more specifically its probe() will fail). > > When IOMMU is either not available (e.g. Amazon EC2) or not acceptable due to > performance overhead and thus VFIO is not an option users that develop > user-space drivers are left without any option but to develop some proprietary > UIO drivers (e.g. igb_uio driver in Intel's DPDK) just to be able to use UIO > infrastructure. > > This series provides a generic solution for this problem while preserving the > original behaviour for devices for which the original uio_pci_generic had worked > before (i.e. INT#x will be used by default). > > New in v5: > - Expanded the commitlog on PATCH1. Looks like you didn't attempt to address any of my review comments. I don't intend to review this until you do. > New in v4: > - Use portable __u32 and __s32 types from asm/types.h for > defining uio_pci_generic_irq_set fields. > - Use proper _IO macros for defining read and write ioctl() > commands. > - Moved bars mapping setting into a separate patch. > - Update uio_pci_generic example in uio-howto.tmpl. > > New in v3: > - Add __iomem qualifier to temp buffer receiving ioremap value. > > New in v2: > - Added #include to uio_pci_generic.c > > > Vlad Zolotarov (4): > uio: add ioctl support > uio_pci_generic: properly initialize PCI bars mappings towards UIO > uio_pci_generic: add MSI/MSI-X support > Documentation: update uio-howto > > Documentation/DocBook/uio-howto.tmpl | 139 ++++++++++-- > drivers/uio/uio.c | 15 ++ > drivers/uio/uio_pci_generic.c | 409 +++++++++++++++++++++++++++++++++-- > include/linux/uio_driver.h | 3 + > include/uapi/linux/uio_pci_generic.h | 51 +++++ > 5 files changed, 574 insertions(+), 43 deletions(-) > create mode 100644 include/uapi/linux/uio_pci_generic.h > > -- > 2.1.0