From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbbJGBZL (ORCPT ); Tue, 6 Oct 2015 21:25:11 -0400 Received: from imap.thunk.org ([74.207.234.97]:35682 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753053AbbJGBZJ (ORCPT ); Tue, 6 Oct 2015 21:25:09 -0400 Date: Tue, 6 Oct 2015 21:25:06 -0400 From: "Theodore Ts'o" To: Alexander Kapshuk Cc: linux-kernel , Jim Davis , richard@nod.at, Greg KH Subject: Re: ver_linux: proposed implementation feedback request Message-ID: <20151007012506.GA24678@thunk.org> Mail-Followup-To: Theodore Ts'o , Alexander Kapshuk , linux-kernel , Jim Davis , richard@nod.at, Greg KH References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 05, 2015 at 08:00:40PM +0300, Alexander Kapshuk wrote: > Thanks very much for everyone's feedback. > > Instead of flooding this mailing list with another bunch of ver_linux > patches, I thought I would post another implementation, and see if you > find any of the proposed changes worth submitting as a patch. I will > be happy with whatever feedback you can give me. And we will leave it > at that. Thanks. Can you also explain what the changes are that you're making? That might be very helpful. I'm also curious if someone suggested that you break apart the patch into a separate one for each program? In my opinion that actually made it harder to review the patch set (especially when I was cc'ed on the one for tune2fs, but not the patch that set $tune2fs :-). My suggestion would be to break it apart by functional changes. If the main change is to support different version numbers emitted by a wide range of version numbers, just say something like: fixed the version number detection of the FOO, BAR, and BAZ packages. Cheers, - Ted