From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962AbbJGGnf (ORCPT ); Wed, 7 Oct 2015 02:43:35 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:34014 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbbJGGne (ORCPT ); Wed, 7 Oct 2015 02:43:34 -0400 Date: Wed, 7 Oct 2015 08:43:31 +0200 From: Jiri Pirko To: Arnd Bergmann Cc: netdev@vger.kernel.org, davem@davemloft.net, Jiri Pirko , Ido Schimmel , linux-kernel@vger.kernel.org, Elad Raz , Scott Feldman , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Message-ID: <20151007064331.GC2152@nanopsycho.orion> References: <30258520.VaA2vDyUiY@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30258520.VaA2vDyUiY@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Oct 06, 2015 at 11:47:44PM CEST, arnd@arndb.de wrote: >The recently added mlxsw driver produces warnings in ARM >allmodconfig: > >drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec': >drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count >= width of type [-Wshift-count-overflow] >linux/byteorder/big_endian.h:38:51: note: in definition of macro '__cpu_to_be32' >drivers/net/ethernet/mellanox/mlxsw/pci.c:76:2: note: in expansion of macro 'iowrite32be' > >This changes the type of the local variable to u64, which gets rid of the >warning and seems nicer than adding #ifdefs. > >Signed-off-by: Arnd Bergmann >Fixes: eda6500a987a "mlxsw: Add PCI bus implementation" Acked-by: Jiri Pirko Thanks!