From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750944AbbJGG4k (ORCPT ); Wed, 7 Oct 2015 02:56:40 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37029 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbbJGG4j (ORCPT ); Wed, 7 Oct 2015 02:56:39 -0400 Date: Wed, 7 Oct 2015 08:56:36 +0200 From: Jiri Pirko To: Joe Perches Cc: Arnd Bergmann , netdev@vger.kernel.org, davem@davemloft.net, Jiri Pirko , Ido Schimmel , linux-kernel@vger.kernel.org, Elad Raz , Scott Feldman , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Message-ID: <20151007065636.GD2152@nanopsycho.orion> References: <30258520.VaA2vDyUiY@wuerfel> <1444200782.26237.8.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444200782.26237.8.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Oct 07, 2015 at 08:53:02AM CEST, joe@perches.com wrote: >On Tue, 2015-10-06 at 23:47 +0200, Arnd Bergmann wrote: >> The recently added mlxsw driver produces warnings in ARM >> allmodconfig: >> >> drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec': >> drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count >= width of type [-Wshift-count-overflow] >> linux/byteorder/big_endian.h:38:51: note: in definition of macro '__cpu_to_be32' >> drivers/net/ethernet/mellanox/mlxsw/pci.c:76:2: note: in expansion of macro 'iowrite32be' >> >> This changes the type of the local variable to u64, which gets rid of the >> warning and seems nicer than adding #ifdefs. > >Using upper_32_bits instead of the shift might be >nicer than changing the type. Wasn't aware of this macro. Indeed this looks more appropriate. Thanks!